You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/29 05:08:35 UTC
[GitHub] [incubator-superset] pengyejun opened a new pull request #9923: fix(#9914): Add upload file max size limit
pengyejun opened a new pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923
### SUMMARY
CSV Upload - add max filesize limit.
To slove https://github.com/apache/incubator-superset/issues/9914
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#discussion_r430869360
##########
File path: superset/config.py
##########
@@ -326,6 +326,7 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
# The file upload folder, when using models with files
UPLOAD_FOLDER = BASE_DIR + "/app/static/uploads/"
UPLOAD_CHUNK_SIZE = 4096
+UPLOAD_MAX_SIZE = 50 * 1024 * 1024
Review comment:
NIT: how about `UPLOAD_MAX_BYTES` to clarify the unit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 71.03% -0.11%
==========================================
Files 585 585
Lines 30741 30878 +137
Branches 3239 3239
==========================================
+ Hits 21870 21934 +64
- Misses 8762 8829 +67
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.97% <ø> (-0.87%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.41% <87.50%> (+0.17%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.22% <0.00%> (-5.60%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...28587f6](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `4.71%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 66.42% -4.72%
==========================================
Files 585 585
Lines 30741 30878 +137
Branches 3239 3239
==========================================
- Hits 21870 20512 -1358
- Misses 8762 10187 +1425
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.35% <87.50%> (+0.10%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 71.00% -0.14%
==========================================
Files 585 184 -401
Lines 30741 18011 -12730
Branches 3239 0 -3239
==========================================
- Hits 21870 12789 -9081
+ Misses 8762 5222 -3540
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.00% <87.50%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `86.44% <80.00%> (-3.04%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [406 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...28587f6](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
+ Coverage 71.14% 71.23% +0.09%
==========================================
Files 585 585
Lines 30741 30878 +137
Branches 3239 3239
==========================================
+ Hits 21870 21996 +126
- Misses 8762 8773 +11
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.77% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.41% <87.50%> (+0.17%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (+<0.01%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <0.00%> (+0.01%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <0.00%> (+0.07%)` | :arrow_up: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pengyejun closed pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
pengyejun closed pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **increase** coverage by `1.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
+ Coverage 71.14% 72.19% +1.05%
==========================================
Files 585 585
Lines 30741 32481 +1740
Branches 3239 3275 +36
==========================================
+ Hits 21870 23450 +1580
- Misses 8762 8922 +160
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.77% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `59.16% <ø> (-0.26%)` | :arrow_down: |
| #python | `73.23% <100.00%> (+1.99%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `93.52% <100.00%> (+4.05%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `47.31% <0.00%> (-23.53%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.35% <0.00%> (-6.16%)` | :arrow_down: |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `33.33% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#discussion_r430869523
##########
File path: superset/exceptions.py
##########
@@ -71,6 +71,10 @@ class CertificateException(SupersetException):
message = _("Invalid certificate")
+class UploadOverFlowException(SupersetException):
Review comment:
NIT: `UploadOverflowException` : lower case `f`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **increase** coverage by `1.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
+ Coverage 71.14% 72.22% +1.07%
==========================================
Files 585 585
Lines 30741 32507 +1766
Branches 3239 3275 +36
==========================================
+ Hits 21870 23477 +1607
- Misses 8762 8921 +159
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.77% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `59.16% <ø> (-0.26%)` | :arrow_down: |
| #python | `73.27% <100.00%> (+2.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `93.52% <100.00%> (+4.05%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `47.31% <0.00%> (-23.53%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.35% <0.00%> (-6.16%)` | :arrow_down: |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `33.33% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 70.99% -0.15%
==========================================
Files 585 585
Lines 30741 30878 +137
Branches 3239 3239
==========================================
+ Hits 21870 21922 +52
- Misses 8762 8841 +79
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.97% <ø> (-0.87%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.35% <87.50%> (+0.10%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.22% <0.00%> (-5.60%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...28587f6](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `4.93%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 66.20% -4.94%
==========================================
Files 585 585
Lines 30741 30751 +10
Branches 3239 3239
==========================================
- Hits 21870 20359 -1511
- Misses 8762 10213 +1451
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.00% <87.50%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `86.44% <80.00%> (-3.04%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [153 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pengyejun closed pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
pengyejun closed pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 71.08% -0.07%
==========================================
Files 585 585
Lines 30741 30986 +245
Branches 3239 3275 +36
==========================================
+ Hits 21870 22025 +155
- Misses 8762 8852 +90
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.77% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `59.16% <ø> (-0.26%)` | :arrow_down: |
| #python | `71.41% <87.50%> (+0.17%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `47.31% <0.00%> (-23.53%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.35% <0.00%> (-6.16%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (+<0.01%)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#discussion_r441882677
##########
File path: superset/views/database/views.py
##########
@@ -65,9 +65,18 @@ def certificate_form_validator(_, field: StringField) -> None:
def upload_stream_write(form_file_field: "FileStorage", path: str):
chunk_size = app.config["UPLOAD_CHUNK_SIZE"]
+ max_size = app.config["UPLOAD_MAX_BYTES"] or float("inf")
with open(path, "bw") as file_description:
while True:
chunk = form_file_field.stream.read(chunk_size)
+ max_size -= len(chunk)
Review comment:
please add the unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pengyejun commented on a change in pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
pengyejun commented on a change in pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#discussion_r430881521
##########
File path: superset/config.py
##########
@@ -326,6 +326,7 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
# The file upload folder, when using models with files
UPLOAD_FOLDER = BASE_DIR + "/app/static/uploads/"
UPLOAD_CHUNK_SIZE = 4096
+UPLOAD_MAX_SIZE = 50 * 1024 * 1024
Review comment:
Thank you very much for your suggestion, it has been adopted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `4.71%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 66.42% -4.72%
==========================================
Files 585 585
Lines 30741 30878 +137
Branches 3239 3239
==========================================
- Hits 21870 20512 -1358
- Misses 8762 10187 +1425
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.35% <87.50%> (+0.10%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...28587f6](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **increase** coverage by `1.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
+ Coverage 71.14% 72.15% +1.01%
==========================================
Files 585 585
Lines 30741 32481 +1740
Branches 3239 3275 +36
==========================================
+ Hits 21870 23436 +1566
- Misses 8762 8936 +174
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.77% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `59.16% <ø> (-0.26%)` | :arrow_down: |
| #python | `73.16% <100.00%> (+1.92%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `91.76% <100.00%> (+2.29%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `47.31% <0.00%> (-23.53%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.35% <0.00%> (-6.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `76.62% <0.00%> (-3.74%)` | :arrow_down: |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `33.33% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **increase** coverage by `1.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
+ Coverage 71.14% 72.45% +1.31%
==========================================
Files 585 585
Lines 30741 32507 +1766
Branches 3239 3275 +36
==========================================
+ Hits 21870 23554 +1684
- Misses 8762 8844 +82
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.23% <ø> (+0.39%)` | :arrow_up: |
| #javascript | `59.16% <ø> (-0.26%)` | :arrow_down: |
| #python | `73.27% <100.00%> (+2.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `93.52% <100.00%> (+4.05%)` | :arrow_up: |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `33.33% <0.00%> (-0.71%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <0.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
+ Coverage 71.14% 71.24% +0.09%
==========================================
Files 585 585
Lines 30741 30878 +137
Branches 3239 3239
==========================================
+ Hits 21870 21998 +128
- Misses 8762 8771 +9
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.82% <ø> (-0.02%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.41% <87.50%> (+0.17%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.51% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (+<0.01%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <0.00%> (+0.01%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <0.00%> (+0.07%)` | :arrow_up: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...28587f6](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `4.82%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 66.31% -4.83%
==========================================
Files 585 585
Lines 30741 30751 +10
Branches 3239 3239
==========================================
- Hits 21870 20393 -1477
- Misses 8762 10179 +1417
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `71.19% <87.50%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `88.98% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...28587f6](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pengyejun closed pull request #9923: fix(#9914) Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
pengyejun closed pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9923: fix(#9914) Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 71.14% 71.00% -0.15%
==========================================
Files 585 184 -401
Lines 30741 18008 -12733
Branches 3239 0 -3239
==========================================
- Hits 21870 12786 -9084
+ Misses 8762 5222 -3540
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.00% <87.50%> (-0.25%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `86.44% <80.00%> (-3.04%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [406 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...83de943](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=h1) Report
> Merging [#9923](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/848ac91bb6f4f773c424e8ca194c9d69d7d8afba&el=desc) will **decrease** coverage by `11.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9923 +/- ##
===========================================
- Coverage 71.14% 59.41% -11.73%
===========================================
Files 585 401 -184
Lines 30741 12740 -18001
Branches 3239 3239
===========================================
- Hits 21870 7570 -14300
+ Misses 8762 4991 -3771
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [319 more](https://codecov.io/gh/apache/incubator-superset/pull/9923/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=footer). Last update [848ac91...c4d9b0a](https://codecov.io/gh/apache/incubator-superset/pull/9923?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9923: fix(#9914): Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#discussion_r430870612
##########
File path: superset/views/database/views.py
##########
@@ -65,9 +65,15 @@ def certificate_form_validator(_, field: StringField) -> None:
def upload_stream_write(form_file_field: "FileStorage", path: str):
chunk_size = app.config["UPLOAD_CHUNK_SIZE"]
+ max_size = app.config["UPLOAD_MAX_SIZE"] or float("inf")
with open(path, "bw") as file_description:
while True:
chunk = form_file_field.stream.read(chunk_size)
+ max_size -= len(chunk)
+ if max_size < 0:
+ raise UploadOverFlowException(
+ _("Upload Max Size %(size)s", size=app.config["UPLOAD_MAX_SIZE"])
Review comment:
NIT: "Exceeded the upload maximum size of %(size)s bytes"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9923: fix(#9914) Add upload file max size limit
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9923:
URL: https://github.com/apache/incubator-superset/pull/9923#issuecomment-634411255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org