You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2020/11/24 19:05:30 UTC
[httpcomponents-core] 06/09: Remove redundant modifiers.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch 5.0.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit d2df5fc99cd4a0d61ea22ebf856e7208116044e8
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Nov 23 11:43:16 2020 -0500
Remove redundant modifiers.
- All methods in a final class are already final.
- All members of an interface are public.
- All inner enums are static.
---
.../org/apache/hc/core5/http/io/support/TerminalServerFilter.java | 2 +-
.../org/apache/hc/core5/http/nio/entity/NoopEntityConsumer.java | 6 +++---
.../hc/core5/http/nio/support/BasicClientExchangeHandler.java | 4 ++--
.../core5/http/nio/support/ImmediateResponseExchangeHandler.java | 8 ++++----
.../main/java/org/apache/hc/core5/http/protocol/HttpContext.java | 2 +-
.../org/apache/hc/core5/reactor/SocksProxyProtocolHandler.java | 2 +-
6 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/io/support/TerminalServerFilter.java b/httpcore5/src/main/java/org/apache/hc/core5/http/io/support/TerminalServerFilter.java
index 5955f68..b10e21a 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/io/support/TerminalServerFilter.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/io/support/TerminalServerFilter.java
@@ -64,7 +64,7 @@ public final class TerminalServerFilter implements HttpFilterHandler {
}
@Override
- public final void handle(
+ public void handle(
final ClassicHttpRequest request,
final HttpFilterChain.ResponseTrigger responseTrigger,
final HttpContext context,
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/NoopEntityConsumer.java b/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/NoopEntityConsumer.java
index b2188f1..d3132f9 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/NoopEntityConsumer.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/NoopEntityConsumer.java
@@ -47,7 +47,7 @@ public final class NoopEntityConsumer implements AsyncEntityConsumer<Void> {
private volatile FutureCallback<Void> resultCallback;
@Override
- public final void streamStart(
+ public void streamStart(
final EntityDetails entityDetails,
final FutureCallback<Void> resultCallback) throws IOException, HttpException {
this.resultCallback = resultCallback;
@@ -59,11 +59,11 @@ public final class NoopEntityConsumer implements AsyncEntityConsumer<Void> {
}
@Override
- public final void consume(final ByteBuffer src) throws IOException {
+ public void consume(final ByteBuffer src) throws IOException {
}
@Override
- public final void streamEnd(final List<? extends Header> trailers) throws IOException {
+ public void streamEnd(final List<? extends Header> trailers) throws IOException {
if (resultCallback != null) {
resultCallback.completed(null);
}
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/BasicClientExchangeHandler.java b/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/BasicClientExchangeHandler.java
index 0cf0f7a..3296afc 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/BasicClientExchangeHandler.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/BasicClientExchangeHandler.java
@@ -175,7 +175,7 @@ public final class BasicClientExchangeHandler<T> implements AsyncClientExchangeH
}
@Override
- public final void failed(final Exception cause) {
+ public void failed(final Exception cause) {
try {
requestProducer.failed(cause);
responseConsumer.failed(cause);
@@ -198,7 +198,7 @@ public final class BasicClientExchangeHandler<T> implements AsyncClientExchangeH
}
@Override
- public final void releaseResources() {
+ public void releaseResources() {
}
}
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/ImmediateResponseExchangeHandler.java b/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/ImmediateResponseExchangeHandler.java
index cc5e214..d165451 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/ImmediateResponseExchangeHandler.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/ImmediateResponseExchangeHandler.java
@@ -91,23 +91,23 @@ public final class ImmediateResponseExchangeHandler implements AsyncServerExchan
}
@Override
- public final int available() {
+ public int available() {
return responseProducer.available();
}
@Override
- public final void produce(final DataStreamChannel channel) throws IOException {
+ public void produce(final DataStreamChannel channel) throws IOException {
responseProducer.produce(channel);
}
@Override
- public final void failed(final Exception cause) {
+ public void failed(final Exception cause) {
responseProducer.failed(cause);
releaseResources();
}
@Override
- public final void releaseResources() {
+ public void releaseResources() {
responseProducer.releaseResources();
}
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpContext.java b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpContext.java
index c0e0651..0d7db11 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpContext.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpContext.java
@@ -50,7 +50,7 @@ import org.apache.hc.core5.http.ProtocolVersion;
public interface HttpContext {
/** The prefix reserved for use by HTTP components. "http." */
- public static final String RESERVED_PREFIX = "http.";
+ String RESERVED_PREFIX = "http.";
/**
* Returns protocol version used in this context.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/reactor/SocksProxyProtocolHandler.java b/httpcore5/src/main/java/org/apache/hc/core5/reactor/SocksProxyProtocolHandler.java
index 73fd246..9d3e72e 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/reactor/SocksProxyProtocolHandler.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/reactor/SocksProxyProtocolHandler.java
@@ -70,7 +70,7 @@ final class SocksProxyProtocolHandler implements IOEventHandler {
private static final byte ATYP_IPV6 = 4;
- private static enum State {
+ private enum State {
SEND_AUTH, RECEIVE_AUTH_METHOD, SEND_USERNAME_PASSWORD, RECEIVE_AUTH, SEND_CONNECT, RECEIVE_RESPONSE_CODE, RECEIVE_ADDRESS_TYPE, RECEIVE_ADDRESS, COMPLETE
}