You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/13 04:49:45 UTC
[GitHub] [pulsar] shustsud opened a new pull request #8554: [C++] Fixed the setting method of linker option.
shustsud opened a new pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554
### Motivation
I don't think the following `--exclude-libs,ALL` are reflected in linker.
[CMakeLists.txt](https://github.com/apache/pulsar/blob/f8080f4eb690d751f1b07ca54c23e1cd7774473f/pulsar-client-cpp/CMakeLists.txt#L214)
I think `--exclude-libs,ALL` needs to be set in `add_link_options`.
[add_link_options](https://cmake.org/cmake/help/latest/command/add_link_options.html)
`add_link_options` can be used from v3.13.
Therefore, fixed(reverted) `add_compile_options` to `set`.([#4071](https://github.com/apache/pulsar/pull/4071))
### Modifications
* Fixed CMakeLists.txt.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727235259
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-726543663
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727220933
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud edited a comment on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud edited a comment on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727212411
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727224156
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727541719
I've pushed a PR #8568 to fix the flaky test. As you can see, the tests were passed without any rerun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727683143
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727199421
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727198502
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727239420
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727243025
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-726574108
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727345722
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727172717
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727227627
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727518214
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727209013
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727231186
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727511188
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727520977
I'll remove the flaky cpp tests of `KeySharedConsumerTest`, so I think you can rebase after I push the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727430173
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727213385
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-726554667
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727246492
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727212411
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-728672931
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727682138
Thank you so much.
I will rebase to this PR once [#8568](https://github.com/apache/pulsar/pull/8568) has been merged into master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727217220
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727825091
Hi, #8568 is merged now. You can rebase and try again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-726752433
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-726742900
@BewareMyPower Please help review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727306035
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727189282
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554#issuecomment-727176842
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8554: [C++] Fixed the setting method of linker option.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org