You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/17 07:04:29 UTC
[PR] [kafka-to-websocket-clients] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
laglangyue opened a new pull request, #19:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/19
this pr inclueds:
Using pekko instead of akka in the document and code.
Using pekko-connectors style by https://github.com/apache/incubator-pekko-connectors/blob/main/.scalafmt.conf,because this module uses 4 spaces for indentation.
Test:
test local by docker 24.0.7 on Mint Linux 21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [kafka-to-websocket-clients] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #19:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/19#issuecomment-1859451034
add terminate() and app closed,it test passed.
```scala
System.in.read(); // let it run until user presses return
actorSystem.terminate();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [kafka-to-websocket-clients] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #19:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/19#issuecomment-1859057927
I think there may be some issues with the implementation here. Kafka client was not closed, Kafka container was closed. Sorry, I will reviewed this PR latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [kafka-to-websocket-clients] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #19:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org