You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Nick Pentreath (JIRA)" <ji...@apache.org> on 2016/06/02 22:31:59 UTC
[jira] [Comment Edited] (SPARK-14811) ML, Graph 2.0 QA: API: New
Scala APIs, docs
[ https://issues.apache.org/jira/browse/SPARK-14811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313208#comment-15313208 ]
Nick Pentreath edited comment on SPARK-14811 at 6/2/16 10:31 PM:
-----------------------------------------------------------------
[~josephkb] [~yanboliang] [~srowen] Question on this - we seem to be inconsistent with the {{@Since}} annotations on param setters. Generally there are none on the getters in shared traits or the class itself. But some classes (e.g. {{ALS}}) have put in full coverage for the param setter methods (e.g. {{setXXX}}). Do we want to try to do this across the board? Or do it for {{2.0.0}}? In which case we missed a few (e.g. {{setRelativeError}} in {{QuantileDiscretizer}}).
was (Author: mlnick):
[~josephkb] [~yanboliang] [~srowen] Question on this - we seem to be inconsistent with the {{@Since}} annotations on param setters. Generally there are none on the getters in shared traits or the class itself. But some classes (e.g. {{ALS}} have put in full coverage for the param setter methods (e.g. {{setXXX}}). Do we want to try to do this across the board? Or do it for {{2.0.0}}? In which case we missed a few (e.g. {{setRelativeError}} in {{QuantileDiscretizer}}).
> ML, Graph 2.0 QA: API: New Scala APIs, docs
> -------------------------------------------
>
> Key: SPARK-14811
> URL: https://issues.apache.org/jira/browse/SPARK-14811
> Project: Spark
> Issue Type: Sub-task
> Components: Documentation, GraphX, ML, MLlib
> Reporter: Joseph K. Bradley
> Assignee: Yanbo Liang
> Priority: Blocker
>
> Audit new public Scala APIs added to MLlib & GraphX. Take note of:
> * Protected/public classes or methods. If access can be more private, then it should be.
> * Also look for non-sealed traits.
> * Documentation: Missing? Bad links or formatting?
> *Make sure to check the object doc!*
> As you find issues, please create JIRAs and link them to this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org