You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2015/09/29 22:05:04 UTC
[GitHub] cordova-plugin-contacts pull request: CB-8537
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/79
CB-8537
Some refactoring, literally factored out repeated code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-contacts CB-8537
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit f8b6fb89f619297be3f536d39a9435cf66289ce4
Author: Rob Close <rob-close>
Date: 2015-02-25T17:32:34Z
CB-8537 Updated source to pass Fortify scan.
Made changes for the following issues:
From Fortify:
Poor Error Handling: Empty Catch Block (Errors, Structural)
And from SonarQube:
Implicitly using the default locale is a common source of bugs: Use
toLowerCase(Locale) instead
commit c91ca15998da557322463d51788a532d8332a920
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-29T18:16:49Z
Merge branch 'CB-8537' of https://github.com/rob-close/cordova-plugin-contacts into CB-8537
commit e8a8ee606c0be98fa8240e16ca9911c5e4e6b933
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-29T19:45:14Z
removed mulitple calls toLowerCase(Locale.getDefault()) for the same string, use type Phone enum directly.
commit fbfde768747c9165752bf6110a21680668498b8c
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-29T19:50:08Z
Shortened multiple references to use CommonDataKinds directly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8537
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org