You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jerroydmoore <gi...@git.apache.org> on 2016/02/26 23:20:04 UTC
[GitHub] cordova-windows pull request: CB-10714 Ignore case for --archs
GitHub user jerroydmoore opened a pull request:
https://github.com/apache/cordova-windows/pull/153
CB-10714 Ignore case for --archs
If "ARM" is passed to --archs, the Appx file is compiled, but the build
will fail due to a case sensitive string comparison.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerroydmoore/cordova-windows CB-10714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit c9305e5224c63f390aeb8d5ef698bf1e3b7b7f4f
Author: Jerroyd Moore <je...@intel.com>
Date: 2016-02-26T22:16:18Z
Ignore case for --archs
If "ARM" is passed to --archs, the Appx file is compiled, but the build
will fail due to a case sensitive string comparison.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10714 Ignore case for --archs
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/153#issuecomment-190507979
@jerroydmoore ping. Sorry, the code fails the CI tests and has been reverted. Please revise and resubmit the PR, and please submit an ICLA (guidelines [here][contributing]).
[contributing]: http://cordova.apache.org/contribute/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10714 Ignore case for --archs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10714 Ignore case for --archs
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/153#issuecomment-190568771
To be clear, an ICLA is not required, but it is prefered.
This was a one liner, and should not get any ICLA scrutiny.
The failed CI tests however mean this should never have been accepted and merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10714 Ignore case for --archs
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/153#issuecomment-190586588
@jerroydmoore, @purplecabbage is right: that was my mistake. The ICLA is not required, but if you plan to contribute more it would be awesome to get it out of the way sooner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org