You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2024/03/30 09:53:52 UTC

[PR] upgrade mssql driver [pekko-projection]

laglangyue opened a new pull request, #126:
URL: https://github.com/apache/pekko-projection/pull/126

   cherry pick
   https://github.com/apache/pekko-persistence-jdbc/pull/161/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade mssql driver [pekko-projection]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #126:
URL: https://github.com/apache/pekko-projection/pull/126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade mssql driver [pekko-projection]

Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #126:
URL: https://github.com/apache/pekko-projection/pull/126#issuecomment-2039318457

   ![image](https://github.com/apache/pekko-projection/assets/35491928/4619d7f4-354c-47e1-84c9-e2e130267133)
   
   
   `org.apache.pekko.projection.kafka.internal.KafkaSourceProviderImplSpec`
   
   This error seems to be frequent in CI, do you know the reason? @pjfanning 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade mssql driver [pekko-projection]

Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #126:
URL: https://github.com/apache/pekko-projection/pull/126#issuecomment-2039320064

   test `KafkaSourceProviderImplSpec` ok in my pc, but failed in CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade mssql driver [pekko-projection]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #126:
URL: https://github.com/apache/pekko-projection/pull/126#issuecomment-2042112006

   > ![image](https://private-user-images.githubusercontent.com/35491928/319934956-4619d7f4-354c-47e1-84c9-e2e130267133.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1NjM2NDUsIm5iZiI6MTcxMjU2MzM0NSwicGF0aCI6Ii8zNTQ5MTkyOC8zMTk5MzQ5NTYtNDYxOWQ3ZjQtMzU0Yy00N2UxLTg0YzktZTJlMTMwMjY3MTMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA4VDA4MDIyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY3NWJhNWEzZjVkZmUzM2IxZjVjN2YwNDAwNTc2NjZiNmZiZTE2Njg3ODI4ZmI2ZmNiZWE4YTRhMmFiMWZjZGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tP0IOZ86A-EU9Mzc4MkAJpxz5tADjzWIfd_Q5GDCJXQ)
   > 
   > `org.apache.pekko.projection.kafka.internal.KafkaSourceProviderImplSpec`
   > 
   > This error seems to be frequent in CI, do you know the reason? @pjfanning
   
   this is a known flaky test (#103). IMHO we should link to flaky tests when we encounter them (to be able to more easily see which flaky tests are in particular need of fixing), and we should re-run the tests until they are green before merging (to avoid accidentally merging with legitimate errors)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade mssql driver [pekko-projection]

Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #126:
URL: https://github.com/apache/pekko-projection/pull/126#issuecomment-2039273744

   @pjfanning cc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade mssql driver [pekko-projection]

Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #126:
URL: https://github.com/apache/pekko-projection/pull/126#issuecomment-2028619317

   I know why it failed, the test code is a bit difficult, and the jdbc url is not configurable. I need some time to understand how to add the params to url


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org