You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/03 00:46:50 UTC

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6631: Shade jackson packages in pinot-spi and pinot-avro-base modules

jackjlli commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586019895



##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
                       <pattern>com.google.common.base</pattern>
                       <shadedPattern>shaded.com.google.common.base</shadedPattern>
                     </relocation>
+                    <relocation>

Review comment:
       pinot-avro-base internally depends on pinot-spi. If we don't shade both, pinot-common would still be pulled. Thus, have to shade two modules.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org