[GitHub] [airflow] michaelmdeng commented on a change in pull request #5755: [AIRFLOW-4568] Add unallowed_states to ExternalTaskSensor

[GitBox <gi...@apache.org>]

michaelmdeng commented on a change in pull request #5755: [AIRFLOW-4568] Add unallowed_states to ExternalTaskSensor
URL: https://github.com/apache/airflow/pull/5755#discussion_r336828589
 
 

 ##########
 File path: airflow/sensors/external_task_sensor.py
 ##########
 @@ -40,6 +40,10 @@ class ExternalTaskSensor(BaseSensorOperator):
     :type external_task_id: str
     :param allowed_states: list of allowed states, default is ``['success']``
     :type allowed_states: list
+    :param unallowed_states: list of unallowed states, default is ``None``. When
 
 Review comment:
   I think we do need to specify both separately because the goal is to change the sensor from an operator that does one of two things (either succeed or continue to poke) to an operator that does one of three things (succeed, continue to poke, or fail outright).
   
   If we specify `unallowed_states` as `NOT allowed_states`, then the operator still only performs one of two actions (succeed or fail outright, with the fail outright action replacing the original continue to poke).
   
   as for the wording, I do think ashb's wording will make it more clear and will update

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services