[jira] [Commented] (MESOS-4850) Add authentication to agent endpoints /state and /flags

["Greg Mann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187921#comment-15187921 ] 

Greg Mann commented on MESOS-4850:
----------------------------------

Reviews here:

https://reviews.apache.org/r/44553/
https://reviews.apache.org/r/44554/

> Add authentication to agent endpoints /state and /flags
> -------------------------------------------------------
>
>                 Key: MESOS-4850
>                 URL: https://issues.apache.org/jira/browse/MESOS-4850
>             Project: Mesos
>          Issue Type: Task
>          Components: security, slave
>            Reporter: Adam B
>            Assignee: Greg Mann
>              Labels: mesosphere, security
>
> The {{/state}} and {{/flags}} endpoints are installed in {{src/slave/slave.cpp}}, and thus are straightforward to make authenticated. Other agent endpoints require a bit more consideration, and are tracked in MESOS-4902.
> For more information on agent endpoints, see http://mesos.apache.org/documentation/latest/endpoints/
> or search for `route(` in the source code:
> {code}
> $ grep -rn "route(" src/ |grep -v master |grep -v tests |grep -v json
> src/version/version.cpp:75:  route("/", VERSION_HELP(), &VersionProcess::version);
> src/files/files.cpp:150:  route("/browse",
> src/files/files.cpp:153:  route("/read",
> src/files/files.cpp:156:  route("/download",
> src/files/files.cpp:159:  route("/debug",
> src/slave/slave.cpp:580:  route("/api/v1/executor",
> src/slave/slave.cpp:595:  route("/state",
> src/slave/slave.cpp:601:  route("/flags",
> src/slave/slave.cpp:607:  route("/health",
> src/slave/monitor.cpp:100:    route("/statistics",
> $ grep -rn "route(" 3rdparty/ |grep -v tests |grep -v README |grep -v examples |grep -v help |grep -v "process..pp"
> 3rdparty/libprocess/include/process/profiler.hpp:34:    route("/start", START_HELP(), &Profiler::start);
> 3rdparty/libprocess/include/process/profiler.hpp:35:    route("/stop", STOP_HELP(), &Profiler::stop);
> 3rdparty/libprocess/include/process/system.hpp:70:    route("/stats.json", statsHelp(), &System::stats);
> 3rdparty/libprocess/include/process/logging.hpp:44:    route("/toggle", TOGGLE_HELP(), &This::toggle);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)