You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Rakesh R (JIRA)" <ji...@apache.org> on 2017/04/23 18:30:04 UTC

[jira] [Updated] (ZOOKEEPER-2731) Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rakesh R updated ZOOKEEPER-2731:
--------------------------------
    Description: 
Please refer the attached sheet in parent jira. Below is the details of findbug warnings.
{code}
MS	org.apache.zookeeper.Environment.JAAS_CONF_KEY isn't final but should be
Bug type MS_SHOULD_BE_FINAL (click for details) 
In class org.apache.zookeeper.Environment
Field org.apache.zookeeper.Environment.JAAS_CONF_KEY
At Environment.java:[line 34]

MS	org.apache.zookeeper.server.ServerCnxn.cmd2String is a mutable collection which should be package protected
Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) 
In class org.apache.zookeeper.server.ServerCnxn
Field org.apache.zookeeper.server.ServerCnxn.cmd2String
At ServerCnxn.java:[line 230]

MS	org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE is a mutable collection
Bug type MS_MUTABLE_COLLECTION (click for details) 
In class org.apache.zookeeper.ZooDefs$Ids
Field org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE
At ZooDefs.java:[line 100]

MS	org.apache.zookeeper.ZooKeeperMain.commandMap is a mutable collection which should be package protected
Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) 
In class org.apache.zookeeper.ZooKeeperMain
Field org.apache.zookeeper.ZooKeeperMain.commandMap
At ZooKeeperMain.java:[line 53]
{code}

  was:
Please refer the attached sheet in parent jira. Below is the details of findbug warnings.
{code}
AT	Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.zookeeper.server.quorum.QuorumCnxManager.handleConnection(Socket, DataInputStream)
AT	Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.zookeeper.server.quorum.QuorumCnxManager.startConnection(Socket, Long)
AT	Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.zookeeper.server.quorum.QuorumCnxManager.toSend(Long, ByteBuffer)
VO	Increment of volatile field org.apache.zookeeper.server.quorum.AuthFastLeaderElection.logicalclock in org.apache.zookeeper.server.quorum.AuthFastLeaderElection.leaveInstance()
VO	Increment of volatile field org.apache.zookeeper.server.quorum.AuthFastLeaderElection.logicalclock in org.apache.zookeeper.server.quorum.AuthFastLeaderElection.lookForLeader()
VO	Increment of volatile field org.apache.zookeeper.server.quorum.FastLeaderElection.logicalclock in org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader()
VO	Increment of volatile field org.apache.zookeeper.server.quorum.QuorumPeer.tick in org.apache.zookeeper.server.quorum.Leader.lead()
VO	Increment of volatile field org.apache.zookeeper.server.quorum.QuorumPeer.tick in org.apache.zookeeper.server.quorum.Leader.lead()
{code}


> Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings
> -----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2731
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2731
>             Project: ZooKeeper
>          Issue Type: Sub-task
>    Affects Versions: 3.4.9
>            Reporter: Rakesh R
>            Assignee: Abraham Fine
>             Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of findbug warnings.
> {code}
> MS	org.apache.zookeeper.Environment.JAAS_CONF_KEY isn't final but should be
> Bug type MS_SHOULD_BE_FINAL (click for details) 
> In class org.apache.zookeeper.Environment
> Field org.apache.zookeeper.Environment.JAAS_CONF_KEY
> At Environment.java:[line 34]
> MS	org.apache.zookeeper.server.ServerCnxn.cmd2String is a mutable collection which should be package protected
> Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) 
> In class org.apache.zookeeper.server.ServerCnxn
> Field org.apache.zookeeper.server.ServerCnxn.cmd2String
> At ServerCnxn.java:[line 230]
> MS	org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE is a mutable collection
> Bug type MS_MUTABLE_COLLECTION (click for details) 
> In class org.apache.zookeeper.ZooDefs$Ids
> Field org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE
> At ZooDefs.java:[line 100]
> MS	org.apache.zookeeper.ZooKeeperMain.commandMap is a mutable collection which should be package protected
> Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) 
> In class org.apache.zookeeper.ZooKeeperMain
> Field org.apache.zookeeper.ZooKeeperMain.commandMap
> At ZooKeeperMain.java:[line 53]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)