You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Ron Yang (JIRA)" <ji...@apache.org> on 2011/09/01 19:14:09 UTC

[jira] [Commented] (HBASE-4206) jenkins hash implementation uses longs unnecessarily

    [ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095435#comment-13095435 ] 

Ron Yang commented on HBASE-4206:
---------------------------------

any chance this patch will be incorporated?

> jenkins hash implementation uses longs unnecessarily
> ----------------------------------------------------
>
>                 Key: HBASE-4206
>                 URL: https://issues.apache.org/jira/browse/HBASE-4206
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>            Reporter: Ron Yang
>            Priority: Minor
>         Attachments: ryang.patch
>
>
> I don't believe you need to use long for a,b,c and as a result no longer need to & against INT_MASK.
> At a minimum the private static longs should be made final, and the "main" method should not print the absolute value of the hash but instead use something like Integer.toHexString

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira