You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by "Nuwan Bandara (JIRA)" <ji...@apache.org> on 2010/04/22 08:47:51 UTC

[jira] Updated: (AXIS2-4400) InputStream left open in AxisService

     [ https://issues.apache.org/jira/browse/AXIS2-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nuwan Bandara updated AXIS2-4400:
---------------------------------

    Attachment: AxisService.patch

Hi, 

I have created a patch with the change. Also looking in to the code base for calls to getResourceAsStream and which are not closed properly.

Regards
/Nuwan

> InputStream left open in AxisService
> ------------------------------------
>
>                 Key: AXIS2-4400
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4400
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>            Reporter: Mike Rheinheimer
>         Attachments: AxisService.patch
>
>
> In kernel module, in org.apache.axis2.description.AxisService starting at line 1250, we have the following code:
> 				InputStream in = getClassLoader().getResourceAsStream(
> 						DeploymentConstants.META_INF + "/" + xsd);
> 				if (in != null) {
>                                     IOUtils.copy(in, out, true);
> 				}
> That 'in' object is never closed, which can result in a memory leak, depending on the underlying class loader implementation.  This InputStream needs to be closed.  The reason I'm opening a Jira instead of just doing the fix, is that I think it's worthwhile to inspect the whole code base for all calls to "getResourceAsStream" just to make sure no others have been overlooked.
> I'll take this Jira as soon as I can.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org