You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ryan Thomas <ry...@ryant.org> on 2014/10/15 12:58:00 UTC
Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout is
provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs
-----
src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Oct. 15, 2014, 4:25 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 480
> > <https://reviews.apache.org/r/26736/diff/1/?file=721615#file721615line480>
> >
> > Does docker stop -t 0 doesn't do this for you?
It will take a slightly different path in docker, but it will end up with the same result. I will update to remove.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56714
-----------------------------------------------------------
On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:58 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Oct. 15, 2014, 4:25 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 479
> > <https://reviews.apache.org/r/26736/diff/1/?file=721615#file721615line479>
> >
> > Also, have you tried with the docker cli what's the exit status when you run docker stop if either 1) docker succesffully stopped 2) docker killed it in the end 3) can't do both
>From reading through the docker code, it appears to be the same as if it failed to kill the container. If it fails to SIGTERM the container (that is it fails to send the signal) it will attempt a SIGKILL on it, the errors returned are the same as the kill path.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56714
-----------------------------------------------------------
On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:58 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56714
-----------------------------------------------------------
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment97097>
Print the timeout value as well.
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment97096>
You can use our to_string method (stringify) instead.
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment97104>
Also, have you tried with the docker cli what's the exit status when you run docker stop if either 1) docker succesffully stopped 2) docker killed it in the end 3) can't do both
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment97098>
Does docker stop -t 0 doesn't do this for you?
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26736/#comment97102>
You can just pass the duration value in.
src/slave/flags.hpp
<https://reviews.apache.org/r/26736/#comment97101>
You're storing this as a duration type, so it actually takes a duration string instead of a number of seconds integer right?
- Timothy Chen
On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:58 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56686
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:58 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: git apply --index 26736.patch
> >
> > Error:
> > error: patch failed: src/docker/docker.cpp:472
> > error: src/docker/docker.cpp: patch does not apply
> > error: patch failed: src/slave/containerizer/docker.cpp:684
> > error: src/slave/containerizer/docker.cpp: patch does not apply
> > error: patch failed: src/slave/flags.hpp:300
> > error: src/slave/flags.hpp: patch does not apply
>
> Ankur Chauhan wrote:
> @Ryan Thomas - do you know what reviewbot is complaining about?
Most likely need to rebase on latest master. Ryan can you rebase?
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56833
-----------------------------------------------------------
On Oct. 15, 2014, 8:30 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 8:30 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: git apply --index 26736.patch
> >
> > Error:
> > error: patch failed: src/docker/docker.cpp:472
> > error: src/docker/docker.cpp: patch does not apply
> > error: patch failed: src/slave/containerizer/docker.cpp:684
> > error: src/slave/containerizer/docker.cpp: patch does not apply
> > error: patch failed: src/slave/flags.hpp:300
> > error: src/slave/flags.hpp: patch does not apply
>
> Ankur Chauhan wrote:
> @Ryan Thomas - do you know what reviewbot is complaining about?
>
> Timothy Chen wrote:
> Most likely need to rebase on latest master. Ryan can you rebase?
I think it is due to how I updated the review, should I just open a new one with the commits squashed?
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56833
-----------------------------------------------------------
On Oct. 15, 2014, 8:30 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 8:30 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ankur Chauhan <an...@malloc64.com>.
> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: git apply --index 26736.patch
> >
> > Error:
> > error: patch failed: src/docker/docker.cpp:472
> > error: src/docker/docker.cpp: patch does not apply
> > error: patch failed: src/slave/containerizer/docker.cpp:684
> > error: src/slave/containerizer/docker.cpp: patch does not apply
> > error: patch failed: src/slave/flags.hpp:300
> > error: src/slave/flags.hpp: patch does not apply
@Ryan Thomas - do you know what reviewbot is complaining about?
- Ankur
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56833
-----------------------------------------------------------
On Oct. 15, 2014, 8:30 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 8:30 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: git apply --index 26736.patch
> >
> > Error:
> > error: patch failed: src/docker/docker.cpp:472
> > error: src/docker/docker.cpp: patch does not apply
> > error: patch failed: src/slave/containerizer/docker.cpp:684
> > error: src/slave/containerizer/docker.cpp: patch does not apply
> > error: patch failed: src/slave/flags.hpp:300
> > error: src/slave/flags.hpp: patch does not apply
>
> Ankur Chauhan wrote:
> @Ryan Thomas - do you know what reviewbot is complaining about?
>
> Timothy Chen wrote:
> Most likely need to rebase on latest master. Ryan can you rebase?
>
> Ryan Thomas wrote:
> I think it is due to how I updated the review, should I just open a new one with the commits squashed?
>
> Timothy Chen wrote:
> I just tried to apply this review myself on latest master and it's failed to merge clealy, so it's definitely just not rebased on latest master.
Ok, rebasing.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56833
-----------------------------------------------------------
On Oct. 17, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: git apply --index 26736.patch
> >
> > Error:
> > error: patch failed: src/docker/docker.cpp:472
> > error: src/docker/docker.cpp: patch does not apply
> > error: patch failed: src/slave/containerizer/docker.cpp:684
> > error: src/slave/containerizer/docker.cpp: patch does not apply
> > error: patch failed: src/slave/flags.hpp:300
> > error: src/slave/flags.hpp: patch does not apply
>
> Ankur Chauhan wrote:
> @Ryan Thomas - do you know what reviewbot is complaining about?
>
> Timothy Chen wrote:
> Most likely need to rebase on latest master. Ryan can you rebase?
>
> Ryan Thomas wrote:
> I think it is due to how I updated the review, should I just open a new one with the commits squashed?
I just tried to apply this review myself on latest master and it's failed to merge clealy, so it's definitely just not rebased on latest master.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56833
-----------------------------------------------------------
On Oct. 15, 2014, 8:30 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 8:30 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56833
-----------------------------------------------------------
Bad patch!
Reviews applied: [26736]
Failed command: git apply --index 26736.patch
Error:
error: patch failed: src/docker/docker.cpp:472
error: src/docker/docker.cpp: patch does not apply
error: patch failed: src/slave/containerizer/docker.cpp:684
error: src/slave/containerizer/docker.cpp: patch does not apply
error: patch failed: src/slave/flags.hpp:300
error: src/slave/flags.hpp: patch does not apply
- Mesos ReviewBot
On Oct. 15, 2014, 8:30 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 8:30 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 17, 2014, 11:02 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: ./support/apply-review.sh -n -r 26736
> >
> > Error:
> > --2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/
> > Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
> > Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
> > HTTP request sent, awaiting response... 200 OK
> > Length: 6047 (5.9K) [text/x-patch]
> > Saving to: '26736.patch'
> >
> > 0K ..... 100% 182M=0s
> >
> > 2014-10-17 23:02:08 (182 MB/s) - '26736.patch' saved [6047/6047]
> >
> > Successfully applied: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
> >
> > Ensure docker calls stop if a docker\_stop\_timeout is provided Added the flag docker\_stop\_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
> >
> >
> > Review: https://reviews.apache.org/r/26736
> > Checking 6 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> > src/docker/docker.cpp:475: Lines should be <= 80 characters long [whitespace/line_length] [2]
> > Total errors found: 1
> > Failed to commit patch
>
> Ankur Chauhan wrote:
> Darn checkstyle. Maybe that should be a part of the commit hook or `make check`.
It is a pre-commit hook, but you need to install the pre-commit hook yourself. It's in the support folder
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review57237
-----------------------------------------------------------
On Oct. 17, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ankur Chauhan <an...@malloc64.com>.
> On Oct. 17, 2014, 11:02 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [26736]
> >
> > Failed command: ./support/apply-review.sh -n -r 26736
> >
> > Error:
> > --2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/
> > Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
> > Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
> > HTTP request sent, awaiting response... 200 OK
> > Length: 6047 (5.9K) [text/x-patch]
> > Saving to: '26736.patch'
> >
> > 0K ..... 100% 182M=0s
> >
> > 2014-10-17 23:02:08 (182 MB/s) - '26736.patch' saved [6047/6047]
> >
> > Successfully applied: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
> >
> > Ensure docker calls stop if a docker\_stop\_timeout is provided Added the flag docker\_stop\_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
> >
> >
> > Review: https://reviews.apache.org/r/26736
> > Checking 6 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> > src/docker/docker.cpp:475: Lines should be <= 80 characters long [whitespace/line_length] [2]
> > Total errors found: 1
> > Failed to commit patch
Darn checkstyle. Maybe that should be a part of the commit hook or `make check`.
- Ankur
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review57237
-----------------------------------------------------------
On Oct. 17, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review57237
-----------------------------------------------------------
Bad patch!
Reviews applied: [26736]
Failed command: ./support/apply-review.sh -n -r 26736
Error:
--2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 6047 (5.9K) [text/x-patch]
Saving to: '26736.patch'
0K ..... 100% 182M=0s
2014-10-17 23:02:08 (182 MB/s) - '26736.patch' saved [6047/6047]
Successfully applied: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Ensure docker calls stop if a docker\_stop\_timeout is provided Added the flag docker\_stop\_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Review: https://reviews.apache.org/r/26736
Checking 6 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/docker/docker.cpp:475: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 1
Failed to commit patch
- Mesos ReviewBot
On Oct. 17, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59460
-----------------------------------------------------------
Can you rebase on latest master? Then I can merge this.
- Timothy Chen
On Oct. 18, 2014, 3:51 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2014, 3:51 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review57262
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Oct. 18, 2014, 3:51 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2014, 3:51 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59480
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 5:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59503
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Nov. 1, 2014, 8:11 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 8:11 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60266
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Nov. 6, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review61318
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Nov. 13, 2014, 8:33 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp 5978ec2fcf91c127ed7a8f12ee3a47e57f4c0f1b
> src/slave/flags.hpp 4ec5954b2e532c9fb3ea83d4d7c06ca4d5a5ca74
> src/tests/docker_containerizer_tests.cpp 66552ad5cb3b6ff978abd7bf388453f874c860f3
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 8:33 p.m.)
Review request for mesos, Benjamin Hindman and Timothy Chen.
Changes
-------
Rebase off master and update fixes from comments.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp 5978ec2fcf91c127ed7a8f12ee3a47e57f4c0f1b
src/slave/flags.hpp 4ec5954b2e532c9fb3ea83d4d7c06ca4d5a5ca74
src/tests/docker_containerizer_tests.cpp 66552ad5cb3b6ff978abd7bf388453f874c860f3
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 11, 2014, 1:24 p.m., Alexander Rukletsov wrote:
> > src/slave/flags.hpp, lines 335-339
> > <https://reviews.apache.org/r/26736/diff/9/?file=753212#file753212line335>
> >
> > Does it make sense to reuse `Flags::executor_shutdown_grace_period`?
I'm not quite sure we want to tie the executor shutdown to docker stop time, as the concepts doesn't seem to be identical. I'm a bit fuzzy with the executor shutdown altogether, that what are we including into "executor" that is specified in the flag. The executor I believe usually is just for CommandExecutor, so if we start including even into docker containers we might want to rename the flag?
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60778
-----------------------------------------------------------
On Nov. 13, 2014, 8:33 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp 5978ec2fcf91c127ed7a8f12ee3a47e57f4c0f1b
> src/slave/flags.hpp 4ec5954b2e532c9fb3ea83d4d7c06ca4d5a5ca74
> src/tests/docker_containerizer_tests.cpp 66552ad5cb3b6ff978abd7bf388453f874c860f3
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 11, 2014, 1:24 p.m., Alexander Rukletsov wrote:
> > src/slave/flags.hpp, lines 335-339
> > <https://reviews.apache.org/r/26736/diff/9/?file=753212#file753212line335>
> >
> > Does it make sense to reuse `Flags::executor_shutdown_grace_period`?
>
> Timothy Chen wrote:
> I'm not quite sure we want to tie the executor shutdown to docker stop time, as the concepts doesn't seem to be identical. I'm a bit fuzzy with the executor shutdown altogether, that what are we including into "executor" that is specified in the flag. The executor I believe usually is just for CommandExecutor, so if we start including even into docker containers we might want to rename the flag?
>
> Alexander Rukletsov wrote:
> I think what we want to have at the end is some sort of task-dependent shutdown timeout. Now we have `executor_shutdown_grace_period` flag, that is available in all containerizers and will be propagated to all executors via CommandInfo. So the docker finalization is not identical to executor shutdown, they seem to me similar enough to share the same flag and mechanism. How about we put a TODO here for now and revisit it when the finalization concept is fleshed out? Maybe it is even worth to file a JIRA, what do you think?
Sounds good, I'll add the TODO and merge this.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60778
-----------------------------------------------------------
On Nov. 13, 2014, 8:33 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp 5978ec2fcf91c127ed7a8f12ee3a47e57f4c0f1b
> src/slave/flags.hpp 4ec5954b2e532c9fb3ea83d4d7c06ca4d5a5ca74
> src/tests/docker_containerizer_tests.cpp 66552ad5cb3b6ff978abd7bf388453f874c860f3
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
> On Nov. 11, 2014, 1:24 p.m., Alexander Rukletsov wrote:
> > src/slave/flags.hpp, lines 335-339
> > <https://reviews.apache.org/r/26736/diff/9/?file=753212#file753212line335>
> >
> > Does it make sense to reuse `Flags::executor_shutdown_grace_period`?
>
> Timothy Chen wrote:
> I'm not quite sure we want to tie the executor shutdown to docker stop time, as the concepts doesn't seem to be identical. I'm a bit fuzzy with the executor shutdown altogether, that what are we including into "executor" that is specified in the flag. The executor I believe usually is just for CommandExecutor, so if we start including even into docker containers we might want to rename the flag?
I think what we want to have at the end is some sort of task-dependent shutdown timeout. Now we have `executor_shutdown_grace_period` flag, that is available in all containerizers and will be propagated to all executors via CommandInfo. So the docker finalization is not identical to executor shutdown, they seem to me similar enough to share the same flag and mechanism. How about we put a TODO here for now and revisit it when the finalization concept is fleshed out? Maybe it is even worth to file a JIRA, what do you think?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60778
-----------------------------------------------------------
On Nov. 13, 2014, 8:33 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp 5978ec2fcf91c127ed7a8f12ee3a47e57f4c0f1b
> src/slave/flags.hpp 4ec5954b2e532c9fb3ea83d4d7c06ca4d5a5ca74
> src/tests/docker_containerizer_tests.cpp 66552ad5cb3b6ff978abd7bf388453f874c860f3
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60778
-----------------------------------------------------------
src/slave/flags.hpp
<https://reviews.apache.org/r/26736/#comment102188>
Does it make sense to reuse `Flags::executor_shutdown_grace_period`?
- Alexander Rukletsov
On Nov. 6, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60468
-----------------------------------------------------------
Ship it!
src/docker/docker.hpp
<https://reviews.apache.org/r/26736/#comment101869>
You should be able to just do:
const Duration& timeout = Seconds(0)
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment101870>
Please pull this const up to the previous line.
- Benjamin Hindman
On Nov. 6, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 9:55 p.m.)
Review request for mesos, Benjamin Hindman and Timothy Chen.
Changes
-------
Rebase from master
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 12:19 a.m.)
Review request for mesos, Benjamin Hindman and Timothy Chen.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60070
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 4, 2014, 9:28 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 9:28 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 9:28 p.m.)
Review request for mesos.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59539
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26736]
All tests passed.
- Mesos ReviewBot
On Nov. 2, 2014, 8:51 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 8:51 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 2, 2014, 8:51 p.m.)
Review request for mesos.
Changes
-------
Remove trailing whitespace.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59533
-----------------------------------------------------------
Bad patch!
Reviews applied: [26736]
Failed command: ./support/apply-review.sh -n -r 26736
Error:
2014-11-02 20:49:40 URL:https://reviews.apache.org/r/26736/diff/raw/ [10915/10915] -> "26736.patch" [1]
26736.patch:52: trailing whitespace.
const string& container,
26736.patch:53: trailing whitespace.
const Duration& timeout,
warning: 2 lines add whitespace errors.
Successfully applied: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Ensure docker calls stop if a docker\_stop\_timeout is provided Added the flag docker\_stop\_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Review: https://reviews.apache.org/r/26736
src/docker/docker.cpp:490: trailing whitespace.
+ const string& container,
src/docker/docker.cpp:491: trailing whitespace.
+ const Duration& timeout,
Failed to commit patch
- Mesos ReviewBot
On Nov. 2, 2014, 8:15 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 8:15 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 2, 2014, 8:15 p.m.)
Review request for mesos.
Changes
-------
Rebase off master and update as per review comments.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59509
-----------------------------------------------------------
src/docker/docker.hpp
<https://reviews.apache.org/r/26736/#comment100779>
Let's provide more comments what the timeout param is for.
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment100780>
Our max line width is 80, so please wrap the params
- Timothy Chen
On Nov. 1, 2014, 8:11 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 8:11 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 1, 2014, 8:11 p.m.)
Review request for mesos.
Changes
-------
Updated with review comments from benh & timc.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Nov. 1, 2014, 6:29 p.m., Timothy Chen wrote:
> > src/tests/docker_containerizer_tests.cpp, line 1179
> > <https://reviews.apache.org/r/26736/diff/5/?file=746638#file746638line1179>
> >
> > s/killing/stopping/g
Fixed.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59482
-----------------------------------------------------------
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 5:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59482
-----------------------------------------------------------
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26736/#comment100760>
s/killing/stopping/g
- Timothy Chen
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 5:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Nov. 1, 2014, 6:44 p.m., Benjamin Hindman wrote:
> > src/slave/containerizer/docker.cpp, lines 875-876
> > <https://reviews.apache.org/r/26736/diff/5/?file=746636#file746636line875>
> >
> > Can we update this comment now that we're no longer doing Docker::rm or Docker::kill? It should have been updated before as well, thanks for helping out!
>
> Ryan Thomas wrote:
> The issue of having to retry a failed rm still exists - so I think this TODO is still valid. The stop still has the remove boolean that will remove the container after a stop.
Originally in the code we were doing a Docker::rm, then we changed it to doing a Docker::kill, now we've changed it again to doing a Docker::stop. I agree that we should try to do a Docker::rm if Docker::stop failed, the comment just makes it sound like we're retrying to do a Docker::rm when in fact we'd be doing it the first time. ;-) Make sense?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59483
-----------------------------------------------------------
On Nov. 6, 2014, 9:55 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Nov. 1, 2014, 6:44 p.m., Benjamin Hindman wrote:
> > src/slave/containerizer/docker.cpp, lines 875-876
> > <https://reviews.apache.org/r/26736/diff/5/?file=746636#file746636line875>
> >
> > Can we update this comment now that we're no longer doing Docker::rm or Docker::kill? It should have been updated before as well, thanks for helping out!
The issue of having to retry a failed rm still exists - so I think this TODO is still valid. The stop still has the remove boolean that will remove the container after a stop.
> On Nov. 1, 2014, 6:44 p.m., Benjamin Hindman wrote:
> > src/tests/docker_containerizer_tests.cpp, lines 2148-2150
> > <https://reviews.apache.org/r/26736/diff/5/?file=746638#file746638line2148>
> >
> > Why do we need this?
Yep - Tim caught this earlier - will remove.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59483
-----------------------------------------------------------
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 5:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59483
-----------------------------------------------------------
src/docker/docker.hpp
<https://reviews.apache.org/r/26736/#comment100761>
We strongly type things like timeout with a Duration, not an int. Otherwise, is this timeout in seconds? Milliseconds? Etc.
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment100762>
Should this comment be in the header instead of in the implementation? Also, using a Duration lets you kill '(seconds)' here.
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment100763>
The style in the code base is to put the operator on the previous line, so please move '+' on previous line. For posterity, same is true with || and &&, e.g., we do:
if (foo &&
bar &&
baz) {
}
Instead of:
if (foo
&& bar
&& baz) {
}
Thanks!
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment100764>
This is where you can convert to seconds.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26736/#comment100766>
Can we update this comment now that we're no longer doing Docker::rm or Docker::kill? It should have been updated before as well, thanks for helping out!
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26736/#comment100767>
Like above, let's update this comment to stay relevant with the code please.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26736/#comment100765>
Woah! Why did this go from 'false' to 'true'? We don't remove the container till later (the default is false so let's just drop this argument all together).
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26736/#comment100768>
Why do we need this?
- Benjamin Hindman
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 5:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59469
-----------------------------------------------------------
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26736/#comment100752>
This is not needed, but I'll remove it for you.
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26736/#comment100753>
This is not needed, but I'll remove it for you.
- Timothy Chen
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 5:13 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
> src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
> src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
> src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
> src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
> src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Nov. 1, 2014, 5:13 p.m.)
Review request for mesos.
Changes
-------
Rebase off of master
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89
src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4
src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b
src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e
src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6
src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 3:51 a.m.)
Review request for mesos.
Changes
-------
Style fixes
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 9:55 p.m.)
Review request for mesos.
Changes
-------
Rebased off master
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1
src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 8:30 p.m.)
Review request for mesos.
Changes
-------
Added patch with review changes.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs (updated)
-----
src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
Diff: https://reviews.apache.org/r/26736/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
> On Oct. 15, 2014, 6:01 p.m., Ankur Chauhan wrote:
> > src/docker/docker.cpp, line 479
> > <https://reviews.apache.org/r/26736/diff/1/?file=721615#file721615line479>
> >
> > I did some digging around in the docker source
> >
> > https://sourcegraph.com/github.com/docker/docker/.GoPackage/github.com/docker/docker/daemon/.def/Container/Stop/.share
> >
> > And it seems like we are safe to call stop with any value (negative/zero/positive). And the SIGTERM gracefully degrades to a kill it fails.
> >
> > We could simplify the code further by always calling stop and completely dropping the kill code path.
It looks like the WaitStop function in docker will wait forever if it is supplied with a negative value, so I think we should keep the negative check in.
Otherwise I agree with simplifying it, a 0 timeout will essentially drop straight into a kill.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56749
-----------------------------------------------------------
On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:58 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ankur Chauhan <an...@malloc64.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review56749
-----------------------------------------------------------
src/docker/docker.cpp
<https://reviews.apache.org/r/26736/#comment97134>
I did some digging around in the docker source
https://sourcegraph.com/github.com/docker/docker/.GoPackage/github.com/docker/docker/daemon/.def/Container/Stop/.share
And it seems like we are safe to call stop with any value (negative/zero/positive). And the SIGTERM gracefully degrades to a kill it fails.
We could simplify the code further by always calling stop and completely dropping the kill code path.
- Ankur Chauhan
On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:58 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1925
> https://issues.apache.org/jira/browse/MESOS-1925
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
> src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
> src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
>
> Diff: https://reviews.apache.org/r/26736/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
> support/mesos-style.py
>
>
> Thanks,
>
> Ryan Thomas
>
>
Re: Review Request 26736: Ensure docker calls stop if a
docker_stop_timeout
is provided Added the flag docker_stop_timeout that defaults to 0,
if the timeout is 0 the a docker kill will be run,
otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
Posted by Ryan Thomas <ry...@ryant.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 10:58 a.m.)
Review request for mesos.
Bugs: MESOS-1925
https://issues.apache.org/jira/browse/MESOS-1925
Repository: mesos-git
Description (updated)
-------
Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Diffs
-----
src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a
src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d
src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba
Diff: https://reviews.apache.org/r/26736/diff/
Testing (updated)
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose
support/mesos-style.py
Thanks,
Ryan Thomas