You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alex Ough <al...@sungard.com> on 2013/12/05 20:30:38 UTC
Review Request 16042: fixed feature for lost event uuid and event type in
the action event messages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16042/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Bug fix for CLOUDSTACK-3190 (action events message published on 'event bus' should have the UUID of the entity for which event generated and event type).
Diffs
-----
api/src/org/apache/cloudstack/context/CallContext.java 2d5aea4
server/src/com/cloud/event/ActionEventUtils.java eba6874
Diff: https://reviews.apache.org/r/16042/diff/
Testing
-------
Confirmed that 'entity' & 'entityuuid' are included in the messages.
[x] 'management-server.ActionEvent.USER-CREATE.User.*':'{"eventDateTime":"2013-12-05 12:45:10 -0600","status":"Completed","description":"Successfully completed creating User. UserName: test2, FirstName :a, LastName: a","event":"USER.CREATE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'
[x] 'management-server.ActionEvent.USER-DELETE.User.*':'{"eventDateTime":"2013-12-05 12:45:38 -0600","status":"Completed","description":"Successfully completed deleting User. UserId: 5","event":"USER.DELETE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'
Thanks,
Alex Ough
Re: Review Request 16042: fixed feature for lost event uuid and event type
in the action event messages
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16042/#review29991
-----------------------------------------------------------
Ship it!
'master' branch commit 100dc368c2ed93e0ca4246ec9818111fb21d41c6
- Murali Reddy
On Dec. 6, 2013, 8:17 p.m., Alex Ough wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16042/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 8:17 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Bug fix for CLOUDSTACK-3190 (action events message published on 'event bus' should have the UUID of the entity for which event generated and event type).
>
>
> Diffs
> -----
>
> server/src/com/cloud/event/ActionEventUtils.java eba6874
>
> Diff: https://reviews.apache.org/r/16042/diff/
>
>
> Testing
> -------
>
> Confirmed that 'entity' & 'entityuuid' are included in the messages.
>
> [x] 'management-server.ActionEvent.USER-CREATE.User.*':'{"eventDateTime":"2013-12-05 12:45:10 -0600","status":"Completed","description":"Successfully completed creating User. UserName: test2, FirstName :a, LastName: a","event":"USER.CREATE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'
>
> [x] 'management-server.ActionEvent.USER-DELETE.User.*':'{"eventDateTime":"2013-12-05 12:45:38 -0600","status":"Completed","description":"Successfully completed deleting User. UserId: 5","event":"USER.DELETE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'
>
>
> Thanks,
>
> Alex Ough
>
>
Re: Review Request 16042: fixed feature for lost event uuid and event type
in the action event messages
Posted by Alex Ough <al...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16042/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 8:17 p.m.)
Review request for cloudstack.
Changes
-------
Made the fix only affect 'ActionEventUtils.java' because it doesn't seem to be good for 'CallContext' class to know about the events. All it does is just to store and retrieve data without knowing what the data is about.
Repository: cloudstack-git
Description
-------
Bug fix for CLOUDSTACK-3190 (action events message published on 'event bus' should have the UUID of the entity for which event generated and event type).
Diffs (updated)
-----
server/src/com/cloud/event/ActionEventUtils.java eba6874
Diff: https://reviews.apache.org/r/16042/diff/
Testing
-------
Confirmed that 'entity' & 'entityuuid' are included in the messages.
[x] 'management-server.ActionEvent.USER-CREATE.User.*':'{"eventDateTime":"2013-12-05 12:45:10 -0600","status":"Completed","description":"Successfully completed creating User. UserName: test2, FirstName :a, LastName: a","event":"USER.CREATE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'
[x] 'management-server.ActionEvent.USER-DELETE.User.*':'{"eventDateTime":"2013-12-05 12:45:38 -0600","status":"Completed","description":"Successfully completed deleting User. UserId: 5","event":"USER.DELETE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'
Thanks,
Alex Ough