[jira] [Commented] (DOXIATOOLS-64) Flaky test DocBookBookSinkTest

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIATOOLS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021875#comment-17021875 ] 

Michael Osipov commented on DOXIATOOLS-64:
------------------------------------------

This is logically wrong. you cannot rely on the string representation for equality. On needs to compare on node level or have a canoincal string representation.

> Flaky test DocBookBookSinkTest
> ------------------------------
>
>                 Key: DOXIATOOLS-64
>                 URL: https://issues.apache.org/jira/browse/DOXIATOOLS-64
>             Project: Maven Doxia Tools
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Minor
>
> Looks like the test assumes too much about attribute order
> FAILURE! - in org.apache.maven.doxia.book.services.renderer.docbook.DocBookBookSinkTest
> testFigure(org.apache.maven.doxia.book.services.renderer.docbook.DocBookBookSinkTest)  Time elapsed: 0.008 sec  <<< FAILURE!
> junit.framework.ComparisonFailure: Wrong figure! expected:<...ileref="figure.jpg" format="JPG...> but was:<...ormat="JPG" fileref="figure.jpg...>
> 	at junit.framework.Assert.assertEquals(Assert.java:81)
> 	at org.apache.maven.doxia.sink.AbstractSinkTest.testFigure(AbstractSinkTest.java:424)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)