You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/06/23 23:22:28 UTC
Re: Review Request 21459: Database-backed implementation of QuotaStore.
> On May 15, 2014, 10:44 p.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java, lines 28-36
> > <https://reviews.apache.org/r/21459/diff/1/?file=581909#file581909line28>
> >
> > Please add docs, particularly to merge.
Thanks for the nudge, added.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21459/#review43170
-----------------------------------------------------------
On May 14, 2014, 9:22 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21459/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 9:22 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
>
>
> Bugs: AURORA-421
> https://issues.apache.org/jira/browse/AURORA-421
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 9c6da081e98e26f33bc556566eafac996732cb62
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 283976ab0554dbe6700bb0d2a1b7702c969227e8
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 53923627c827131ee4bd93e5c4865d042aee501b
> src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21459/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>