You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2017/09/20 13:05:04 UTC
[GitHub] brooklyn-server pull request #834: Modular catalog.bom
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/834
Modular catalog.bom
This reuses each bundle's `catalog.bom` file to build global `catalog.bom`. It replaces `karaf/init/src/main/resources/catalog-classes.bom` by `karaf/init/src/main/resources/catalog.bom`
It avoids the duplication of bom files and keep all the metadata (title, description, iconUrl, etc) under the same module that contains the actual Java entity.
Those changes spans across `brooklyn-server`, `brooklyn-library` and `brooklyn-dist`. Will link to those PRs once available.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-server update/reuse-bom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #834
----
commit c07484803041523d9fad6d9853f21622b27862a6
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2017-09-20T10:54:44Z
Reuse each bundle's catalog.bom file to build global catalog.bom
----
---
[GitHub] brooklyn-server pull request #834: Modular catalog.bom
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/834
---
[GitHub] brooklyn-server issue #834: Modular catalog.bom
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/834
@tbouron conflicts should be trivial to resolve if you `git merge` #842 here (or rebase on that if that's easier)
---
[GitHub] brooklyn-server issue #834: Modular catalog.bom
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/834
Indeed, just rebased on latest master @ahgittin
---
[GitHub] brooklyn-server issue #834: Modular catalog.bom
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/834
#842 is merged so simply merging master in to this should fix things without too much irritation
---