You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/08/07 12:22:05 UTC

[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #10151: [Fuzzing] add fuzzing test

JosiahWI commented on code in PR #10151:
URL: https://github.com/apache/trafficserver/pull/10151#discussion_r1285790091


##########
CMakeLists.txt:
##########
@@ -323,6 +324,13 @@ set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
 add_compile_definitions(${HOST_OS} PACKAGE_NAME="ats" PACKAGE_VERSION="${TS_VERSION_STRING}")
 add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-Wno-invalid-offsetof>)
 
+# Enable fuzzing
+if(ENABLE_FUZZING)
+    if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")

Review Comment:
   Why `MATCHES` instead of `STREQUAL`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org