[GitHub] [iceberg] stevenzwu commented on a change in pull request #3061: Flink: Fix the warning in FlinkSink

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #3061:
URL: https://github.com/apache/iceberg/pull/3061#discussion_r701192996



##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -249,7 +249,7 @@ public Builder uidPrefix(String newPrefix) {
       return this;
     }
 
-    public DataStreamSink<RowData> build() {
+    public DataStreamSink<Void> build() {

Review comment:
       technically, this is a breaking change if users store the return value into a variable, although in theory I can't think of a valid reason to do so.
   ```
       DataStreamSink<RowData> sink = FlinkSink.forRowData(dataStream)
           ...
           .build();
       // do sth with the sink like override/set name, uid etc.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org