You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/25 15:25:15 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
ztzg opened a new pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739
* `testGlobalOutstandingRequestThrottlingWithRequestThrottlerDisabled`: Only resume after looking at metrics
Resuming the pipeline before looking at the metrics triggers a race between the test and other server threads, causing us to sometimes observe a larger `prep_processor_request_queued` than expected.
The corresponding failures look like this:
RequestThrottlerTest.testGlobalOutstandingRequestThrottlingWithRequestThrottlerDisabled:340 expected: <3> but was: <7>
The metric we look at is updated at the front of the pipeline, before the portion blocked by `resumeProcess`; we don't have to wait for the latter to observe the effect of the global outstanding limit.
* `testLargeRequestThrottling`: Allow more time for request ingestion
The 5s timeout used before this patch was sometimes not sufficient for the server to process the five requests of interest. The corresponding failures look like this:
RequestThrottlerTest.testLargeRequestThrottling:297 expected: <2> but was: <0>
or this:
RequestThrottlerTest.testLargeRequestThrottling:299 expected: <5> but was: <4>
We can use a higher timeout value as the `await` normally quickly terminates with the countdown reaching zero (as opposed to timing out); the increase in duration is only paid on loaded (and slow) executors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739#issuecomment-907039379
Pushed to master and 3.7. Thanks @ztzg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739#issuecomment-910016343
Perfect; thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739#issuecomment-905629669
This applies to `branch-3.7` as well as `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739#issuecomment-910016343
Perfect; thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739#issuecomment-905608864
@hanm: Could you double-check and/or review this, in particular my change to `testGlobalOutstandingRequestThrottlingWithRequestThrottlerDisabled`? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1739: ZOOKEEPER-4327: RequestThrottlerTest: Flakiness remediations
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1739:
URL: https://github.com/apache/zookeeper/pull/1739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org