You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/09/02 12:07:30 UTC

[royale-asjs] branch develop updated: jewel-datagrid: solve strange bug in retrieval of DataGridColumnList PM. Seems a compiler's bug. I left commented the previous line so others can take a look for a compiler bug (@Josh, @Greg, ...)

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 5d09772  jewel-datagrid: solve strange bug in retrieval of DataGridColumnList PM. Seems a compiler's bug. I left commented the previous line so others can take a look for a compiler bug (@Josh, @Greg,...)
5d09772 is described below

commit 5d097725bcddf68393aa9411e362b13d9917c039
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Sep 2 14:07:18 2020 +0200

    jewel-datagrid: solve strange bug in retrieval of DataGridColumnList PM. Seems a compiler's bug. I left commented the previous line so others can take a look for a compiler bug (@Josh, @Greg,...)
---
 .../royale/org/apache/royale/jewel/beads/views/DataGridView.as     | 7 +++++--
 .../royale/jewel/supportClasses/datagrid/IDataGridColumnList.as    | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as
index 89822da..869a8e2 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as
@@ -45,7 +45,6 @@ package org.apache.royale.jewel.beads.views
 	import org.apache.royale.jewel.supportClasses.datagrid.IDataGridColumn;
 	import org.apache.royale.jewel.supportClasses.datagrid.IDataGridColumnList;
 	import org.apache.royale.jewel.supportClasses.datagrid.IDataGridPresentationModel;
-	import org.apache.royale.jewel.supportClasses.list.IListPresentationModel;
 	import org.apache.royale.utils.IEmphasis;
 	import org.apache.royale.utils.loadBeadFromValuesManager;
 	import org.apache.royale.utils.observeElementSize;
@@ -189,7 +188,10 @@ package org.apache.royale.jewel.beads.views
          * @royaleignorecoercion org.apache.royale.core.IBead
          * @royaleignorecoercion org.apache.royale.core.IChild
          * @royaleignorecoercion org.apache.royale.core.IParent
+         * @royaleignorecoercion org.apache.royale.events.IEventDispatcher
          * @royaleignorecoercion org.apache.royale.jewel.supportClasses.datagrid.IDataGridColumn
+         * @royaleignorecoercion org.apache.royale.jewel.supportClasses.datagrid.IDataGridColumnList
+         * @royaleignorecoercion org.apache.royale.jewel.beads.models.DataGridColumnListPresentationModel
          */
         protected function createLists():void
         {
@@ -234,7 +236,8 @@ package org.apache.royale.jewel.beads.views
 
                 (_listArea as IParent).addElement(list as IChild);
 
-                var pm:DataGridColumnListPresentationModel = list.getBeadByType(IListPresentationModel) as DataGridColumnListPresentationModel;
+                // var pm:DataGridColumnListPresentationModel = list.getBeadByType(IListPresentationModel) as DataGridColumnListPresentationModel;
+                var pm:DataGridColumnListPresentationModel = list.presentationModel as DataGridColumnListPresentationModel;
                 pm.rowHeight = _presentationModel.rowHeight;
                 pm.variableRowHeight = false;
                 pm.align = dataGridColumn.align;
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/IDataGridColumnList.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/IDataGridColumnList.as
index 80ef65b..d37a98a 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/IDataGridColumnList.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/IDataGridColumnList.as
@@ -18,6 +18,7 @@
 ////////////////////////////////////////////////////////////////////////////////
 package org.apache.royale.jewel.supportClasses.datagrid
 {
+    import org.apache.royale.core.IListWithPresentationModel;
     import org.apache.royale.html.supportClasses.IDataGridColumnList;
     import org.apache.royale.jewel.DataGrid;
     import org.apache.royale.utils.IEmphasis;
@@ -30,7 +31,7 @@ package org.apache.royale.jewel.supportClasses.datagrid
      *  @playerversion AIR 2.6
      *  @productversion Royale 0.9.7
      */
-    public interface IDataGridColumnList extends org.apache.royale.html.supportClasses.IDataGridColumnList, IEmphasis
+    public interface IDataGridColumnList extends org.apache.royale.html.supportClasses.IDataGridColumnList, IEmphasis, IListWithPresentationModel
     {
         function get rollOverIndex():int;
         function set rollOverIndex(value:int):void;