You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/04 01:49:00 UTC

[jira] [Work logged] (BEAM-11519) Adding PYPI_INSTALL_REQ role and SDK container support

     [ https://issues.apache.org/jira/browse/BEAM-11519?focusedWorklogId=547390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547390 ]

ASF GitHub Bot logged work on BEAM-11519:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Feb/21 01:48
            Start Date: 04/Feb/21 01:48
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #13606:
URL: https://github.com/apache/beam/pull/13606#discussion_r569885297



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1342,7 +1342,11 @@ message StandardArtifacts {
   enum Roles {
     // A URN for staging-to role.
     // payload: ArtifactStagingToRolePayload
-    STAGING_TO  = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+    STAGING_TO        = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+
+    // A URN for pypi-install-requirement role.
+    // payload: None
+    PYPI_INSTALL_REQUIREMENT  = 1 [(beam_urn) = "beam:artifact:role:pypi_install_requirement:v1"];

Review comment:
       It's unclear here whether this is for requirements.txt files or actual tarballs that should be installed.
   
   Could we call this either PYTHON_PACKAGES or PIP_REQUIREMENTS_FILE?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 547390)
    Time Spent: 7h 10m  (was: 7h)

> Adding PYPI_INSTALL_REQ role and SDK container support
> ------------------------------------------------------
>
>                 Key: BEAM-11519
>                 URL: https://issues.apache.org/jira/browse/BEAM-11519
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-model, cross-language, sdk-py-harness
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> Adding PYPI_INSTALL_REQ role and SDK container support



--
This message was sent by Atlassian Jira
(v8.3.4#803005)