You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2013/01/14 08:44:13 UTC

Review Request: Userguide on trunk is missing some memory channel props

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8939/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Userguide is missing:
byteCapacityBufferPercentage (default is 20)
byteCapacity (default seems to be 80% of -Xmx value, measured in bytes)


This addresses bug FLUME-1834.
    https://issues.apache.org/jira/browse/FLUME-1834


Diffs
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b 

Diff: https://reviews.apache.org/r/8939/diff/


Testing
-------


Thanks,

Alexander Alten-Lorenz


Re: Review Request 8939: FLUME-1834: Userguide on trunk is missing some memory channel props

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8939/#review23346
-----------------------------------------------------------

Ship it!


already committed, closing

- Alexander Alten-Lorenz


On Jan. 24, 2013, 10:47 a.m., Alexander Alten-Lorenz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8939/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 10:47 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-1834
>     https://issues.apache.org/jira/browse/FLUME-1834
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Userguide is missing:
> byteCapacityBufferPercentage (default is 20)
> byteCapacity (default seems to be 80% of -Xmx value, measured in bytes)
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b 
> 
> Diff: https://reviews.apache.org/r/8939/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Alten-Lorenz
> 
>


Re: Review Request: FLUME-1834: Userguide on trunk is missing some memory channel props

Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8939/#review15725
-----------------------------------------------------------


Alex, thanks for the patch! I'd like to add some more detail to it. I'll post another patch to the JIRA that builds on top of the one you have posted here.

- Mike Percy


On Jan. 24, 2013, 10:47 a.m., Alexander Alten-Lorenz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8939/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 10:47 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Userguide is missing:
> byteCapacityBufferPercentage (default is 20)
> byteCapacity (default seems to be 80% of -Xmx value, measured in bytes)
> 
> 
> This addresses bug FLUME-1834.
>     https://issues.apache.org/jira/browse/FLUME-1834
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b 
> 
> Diff: https://reviews.apache.org/r/8939/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Alten-Lorenz
> 
>


Re: Review Request: FLUME-1834: Userguide on trunk is missing some memory channel props

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8939/
-----------------------------------------------------------

(Updated Jan. 24, 2013, 10:47 a.m.)


Review request for Flume.


Summary (updated)
-----------------

FLUME-1834: Userguide on trunk is missing some memory channel props


Description
-------

Userguide is missing:
byteCapacityBufferPercentage (default is 20)
byteCapacity (default seems to be 80% of -Xmx value, measured in bytes)


This addresses bug FLUME-1834.
    https://issues.apache.org/jira/browse/FLUME-1834


Diffs
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b 

Diff: https://reviews.apache.org/r/8939/diff/


Testing
-------


Thanks,

Alexander Alten-Lorenz