You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/02/13 03:11:00 UTC

[jira] [Commented] (HBASE-20300) Minor refactor for RpcExecutor

    [ https://issues.apache.org/jira/browse/HBASE-20300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766725#comment-16766725 ] 

Hadoop QA commented on HBASE-20300:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} | {color:red} HBASE-20300 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20300 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12916749/HBASE-20300.v0.patch |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15949/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Minor refactor for RpcExecutor
> ------------------------------
>
>                 Key: HBASE-20300
>                 URL: https://issues.apache.org/jira/browse/HBASE-20300
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HBASE-20300.v0.patch, HBASE-20300.v0.patch.patch
>
>
> Plan to do the following changes.
>  # make Handler be static class
>  # move the threadlocal variables of MonitoredRPCHandler from RpcServer to FifoRpcScheduler since only FifoRpcScheduler use it
>  # create MonitoredRPCHandler in Handler constuction instead of saving the MonitoredRPCHandler in threadlocal variables. In FPBQ mode, the web UI can display all Handlers info even if the rpc Handlers are not used yet.
>  # Threshhold -> Threshold
>  # make RpcExecutor extend ConfigurationObserver
>  # don't create task filter repeatly
>  # add a ut to check whether each Handler has created own MonitoredTask even if no ops
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)