[GitHub] [ignite] Vladsz83 commented on issue #7446: IGNITE-12464 : Service metrics

[GitBox <gi...@apache.org>]

Vladsz83 commented on issue #7446: IGNITE-12464 : Service metrics
URL: https://github.com/apache/ignite/pull/7446#issuecomment-606761243
 
 
   @ivandasch, Hi. Thank you!
   
   >>> Also, I suppose, that we should leave to user the final conclusion to instrument methods of
   his or her service or not. I ... annotation like @Metered or @Timed, with bunch of configurable parameters. ...
   
   What if we introduce system parameter like "SERVICE_METRICS_ENABLED" with default “true” and overriding annotations @MetricsEnabled, @MetricsDisabled. This parameter might be switched through JMX. You’ll be able to disable metrics for every service but a certain one. Or to enable metrics for most of your services with an exception of couple. Or even to enable metrics for certain methods in one service.
   Why I propose system parameter is that it causes fewer code changes/recompilations. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services