[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1450: [TRAVIS] Run tests with mysql database

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1450: [TRAVIS] Run tests with mysql database
URL: https://github.com/apache/netbeans/pull/1450#discussion_r320014136
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -179,3 +178,20 @@ matrix:
              ide/xml.xdm
              ide/xsl"
           jdk: openjdk8
+
+        - name: "Tests with mysql database"
+          jdk: openjdk8
+          services:
+            - mysql
+          env:
+            - OPTS="-quiet -Dcluster.config=minimal -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false"
+            - OPTS_TEST="-Dtest-unit-sys-prop.ignore.random.failures=true -Dvanilla.javac.exists=true -Dtest-unit-sys-prop.mysql.user=root -Dtest-unit-sys-prop.mysql.password=password"
+          before_script:
+            - echo "ALTER USER root@'localhost' IDENTIFIED BY 'password';\nFLUSH PRIVILEGES;\n" | mysql -u root
+            - wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/5.1.23/mysql-connector-java-5.1.23.jar -O $HOME/mysql-connector-java-5.1.23.jar
+            - wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.17/mysql-connector-java-8.0.17.jar -O $HOME/mysql-connector-java-8.0.17.jar
 
 Review comment:
   @blackleg to your questions:
   
   Yes you need a `-license.txt` file, it is required for all dependencies. For GPLed dependencies there are two constraints:
   1) there needs to be a "Type" header, which marks it as "compile-time": https://github.com/apache/netbeans/blob/master/ide/derby/external/derby-10.14.1.0-license.txt#L5
   2) there needs to be a "Comment" header, that explains why the dependency is there
   
   For 2) stating, that the driver is required for the unittests of the DB support would be a valid explaination.
   
   
   Adding the file to the `binaries-list` file just downloads it, it is not automatically packed for distribution or added to a classpath. So yes, you can reference it as shown in your example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists