You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Charlie Dobbie (JIRA)" <ji...@apache.org> on 2007/03/30 15:12:25 UTC

[jira] Created: (WICKET-437) AjaxLink does not respect FLAG_ENABLED

AjaxLink does not respect FLAG_ENABLED
--------------------------------------

                 Key: WICKET-437
                 URL: https://issues.apache.org/jira/browse/WICKET-437
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.2.5
         Environment: All
            Reporter: Charlie Dobbie


Link respects the enabled state of the component, reverting to a do-nothing span tag.  AjaxLink does not respect the enabled state, and will remain active regardless.  In the name of consistency, I believe AjaxLink should behave similarly to Link in this respect.

At the moment I am using the following code in my AjaxLink subclasses.

protected void onComponentTag(ComponentTag tag) {
	super.onComponentTag(tag);
	if(!isEnabled()) {
		tag.setName("span");
		tag.remove("href");
		tag.remove("onclick");
	}
}

This code works for me, but may need to be expanded to cover all eventualities!


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-437) AjaxLink does not respect FLAG_ENABLED

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-437.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

dont think we will fix this in 1.2.5, but it is fixed in 1.3

> AjaxLink does not respect FLAG_ENABLED
> --------------------------------------
>
>                 Key: WICKET-437
>                 URL: https://issues.apache.org/jira/browse/WICKET-437
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.2.5
>         Environment: All
>            Reporter: Charlie Dobbie
>         Assigned To: Igor Vaynberg
>             Fix For: 1.3
>
>
> Link respects the enabled state of the component, reverting to a do-nothing span tag.  AjaxLink does not respect the enabled state, and will remain active regardless.  In the name of consistency, I believe AjaxLink should behave similarly to Link in this respect.
> At the moment I am using the following code in my AjaxLink subclasses.
> protected void onComponentTag(ComponentTag tag) {
> 	super.onComponentTag(tag);
> 	if(!isEnabled()) {
> 		tag.setName("span");
> 		tag.remove("href");
> 		tag.remove("onclick");
> 	}
> }
> This code works for me, but may need to be expanded to cover all eventualities!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-437) AjaxLink does not respect FLAG_ENABLED

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-437:
------------------------------------

    Assignee: Igor Vaynberg

> AjaxLink does not respect FLAG_ENABLED
> --------------------------------------
>
>                 Key: WICKET-437
>                 URL: https://issues.apache.org/jira/browse/WICKET-437
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.2.5
>         Environment: All
>            Reporter: Charlie Dobbie
>         Assigned To: Igor Vaynberg
>             Fix For: 1.3
>
>
> Link respects the enabled state of the component, reverting to a do-nothing span tag.  AjaxLink does not respect the enabled state, and will remain active regardless.  In the name of consistency, I believe AjaxLink should behave similarly to Link in this respect.
> At the moment I am using the following code in my AjaxLink subclasses.
> protected void onComponentTag(ComponentTag tag) {
> 	super.onComponentTag(tag);
> 	if(!isEnabled()) {
> 		tag.setName("span");
> 		tag.remove("href");
> 		tag.remove("onclick");
> 	}
> }
> This code works for me, but may need to be expanded to cover all eventualities!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.