You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/15 08:59:42 UTC

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #706: OAK-9938: Fix initialization of BlobStore in GenerateVersionInconsistencyReport

mreutegg commented on code in PR #706:
URL: https://github.com/apache/jackrabbit-oak/pull/706#discussion_r971721247


##########
oak-run/src/main/java/org/apache/jackrabbit/oak/run/GenerateVersionInconsistencyReport.java:
##########
@@ -95,6 +95,8 @@ private void generateReport(String adminUser, String adminPwd, String...args) th
         DocumentNodeStore dns = null;
         try {
             DocumentNodeStoreBuilder<?> builder = Utils.createDocumentMKBuilder(args, closer, h);
+            // Getting blobstore to trigger it to use MemoryBlobStore
+            builder.getBlobStore();

Review Comment:
   I think it would be better to explicitly set a MemoryBlobStore. But I'm also fine with this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org