You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "serhiy-bzhezytskyy (via GitHub)" <gi...@apache.org> on 2026/08/21 16:52:16 UTC
[PR] SOLR-18356: Remove DocsStreamer.convertLuceneDocToSolrDoc(Document, IndexSchema) [solr]
serhiy-bzhezytskyy opened a new pull request, #4789:
URL: https://github.com/apache/solr/pull/4789
## What
Removes the deprecated 2-arg `DocsStreamer.convertLuceneDocToSolrDoc(Document, IndexSchema)` overload. Deprecated since SOLR-11891 (2018-03-19, Chris Hostetter) in favor of the 3-arg `convertLuceneDocToSolrDoc(Document, IndexSchema, ReturnFields)` version, which is also more efficient (avoids converting fields that aren't needed).
## Verification performed before removing
- Grepped every call site of `convertLuceneDocToSolrDoc` in the tree: both production callers (`TextResponseWriter`, `SolrDocumentFetcher`) and the one test file exercising it (`ReturnFieldsTest`, via a static import of the method name) already call the 3-arg version.
- Zero callers of the 2-arg overload anywhere in the repo.
- Full-repo `./gradlew compileTestJava` (exit 0) confirms no remaining references, not just in the modules touched.
- `ReturnFieldsTest` green.
## Changelog
`DocsStreamer` is part of `solr-core` (a published Maven artifact) and this was a `public static` method, so a `type: removed` changelog entry is included.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18356: Remove DocsStreamer.convertLuceneDocToSolrDoc(Document, IndexSchema) [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4789:
URL: https://github.com/apache/solr/pull/4789#issuecomment-5377483098
Thanks.
Going forward Serhiy, on removals, don't bother with a changelog unless we recommend one. I strongly feel the changelog should be removed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18356: Remove DocsStreamer.convertLuceneDocToSolrDoc(Document, IndexSchema) [solr]
Posted by "serhiy-bzhezytskyy (via GitHub)" <gi...@apache.org>.
serhiy-bzhezytskyy commented on PR #4789:
URL: https://github.com/apache/solr/pull/4789#issuecomment-5378292265
Removed the changelog file. Noted on the going-forward rule -- will default to no changelog on removals unless you or Eric recommend one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18356: Remove DocsStreamer.convertLuceneDocToSolrDoc(Document, IndexSchema) [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #4789:
URL: https://github.com/apache/solr/pull/4789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org