You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/04/23 02:16:11 UTC
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request
#3493: Move TO DS nonversioned logic to separate file.
mitchell852 commented on a change in pull request #3493: Move TO DS nonversioned logic to separate file.
URL: https://github.com/apache/trafficcontrol/pull/3493#discussion_r277497033
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -78,7 +78,7 @@ type DeliveryService struct {
}
type DeliveryServiceV13 struct {
- DeliveryServiceV12
+ DeliveryServiceV11
DeepCachingType DeepCachingType `json:"deepCachingType"`
FQPacingRate int `json:"fqPacingRate,omitempty"`
Review comment:
do you think in the nullable structs you can get rid of the omitempty's? not sure how these got in here. probably just a misunderstanding of how the api works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services