You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mikael Petterson <mi...@ericsson.com> on 2016/08/26 10:36:56 UTC
Help to submit fix in maven-changes-plugin
Hi,
We are trying to use 2.12 of this plugin.
I notice that the filter that we set in not applied at all.
I found the following bug report:
MCHANGES-373: It is not possible to use "filter" parameter
I checked code and I can see that the jql query is missing the filter parameter to be set in the builder.
Easy fix.
I checked out the code:
https://github.com/apache/maven-plugins
I changed the code.
How can I submit a patch and integrate it and test it? Make a release 2.13. What is the process? Is there a guide?
Br,
//mikael
Re: Help to submit fix in maven-changes-plugin
Posted by Tibor Digana <ti...@googlemail.com>.
>>How can I submit a patch
Just push you commit and in the webpage https://github.com/<your
login>/maven-plugins
you will see a hint to open pull request.
Name it "[MCHANGES-373] <jira title>".
Done.
>>and integrate it
The ASF PMC and committers will integrate it.
>> and test it
You should run :
mvn -Prun-its verify
and see if and unit and IT tests passed successfully.
On 8/26/16, Mikael Petterson <mi...@ericsson.com> wrote:
> Hi,
>
> We are trying to use 2.12 of this plugin.
>
> I notice that the filter that we set in not applied at all.
>
> I found the following bug report:
>
> MCHANGES-373: It is not possible to use "filter" parameter
>
> I checked code and I can see that the jql query is missing the filter
> parameter to be set in the builder.
> Easy fix.
>
> I checked out the code:
>
> https://github.com/apache/maven-plugins
>
> I changed the code.
>
> How can I submit a patch and integrate it and test it? Make a release 2.13.
> What is the process? Is there a guide?
>
> Br,
>
> //mikael
>
>
>
>
>
--
Cheers
Tibor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: Help to submit fix in maven-changes-plugin
Posted by Mikael Petterson <mi...@ericsson.com>.
Hi,
I have now created a pull request for it:
https://github.com/apache/maven-plugins/pull/91
What will happen now?
Br,
//mikael
-----Original Message-----
From: Tibor Digana [mailto:tibordigana@apache.org]
Sent: den 28 augusti 2016 11:09
To: dev@maven.apache.org
Subject: Re: Help to submit fix in maven-changes-plugin
Mikael, your patch should appear in
https://github.com/apache/maven-plugins/pulls
Many people do this.
Please read tutorial on GitHub to push a new pull request.
On 8/28/16, Mikael Petterson [via Maven] <ml...@n5.nabble.com> wrote:
>
>
> Hi,
>
> We are trying to use 2.12 of this plugin.
>
> I notice that the filter that we set in not applied at all.
>
> I found the following bug report:
>
> MCHANGES-373: It is not possible to use "filter" parameter
>
> I checked code and I can see that the jql query is missing the filter
> parameter to be set in the builder.
> Easy fix.
>
> I checked out the code:
>
> https://github.com/apache/maven-plugins
>
> I changed the code.
>
> How can I submit a patch and integrate it and test it? Make a release 2.13.
> What is the process? Is there a guide?
>
> Br,
>
> //mikael
>
>
>
>
>
>
>
>
> _______________________________________________
> If you reply to this email, your message will be added to the
> discussion
> below:
> http://maven.40175.n5.nabble.com/Help-to-submit-fix-in-maven-changes-p
> lugin-tp5878947.html To start a new topic under Maven Developers,
> email
> ml-node+s40175n142166h86@n5.nabble.com
> To unsubscribe from Maven Developers, visit
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubs
> cribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ
> 8LTI4OTQ5MjEwMg==
--
Cheers
Tibor
--
View this message in context: http://maven.40175.n5.nabble.com/Help-to-submit-fix-in-maven-changes-plugin-tp5878947p5878960.html
Sent from the Maven Developers mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Help to submit fix in maven-changes-plugin
Posted by Tibor Digana <ti...@apache.org>.
Mikael, your patch should appear in
https://github.com/apache/maven-plugins/pulls
Many people do this.
Please read tutorial on GitHub to push a new pull request.
On 8/28/16, Mikael Petterson [via Maven]
<ml...@n5.nabble.com> wrote:
>
>
> Hi,
>
> We are trying to use 2.12 of this plugin.
>
> I notice that the filter that we set in not applied at all.
>
> I found the following bug report:
>
> MCHANGES-373: It is not possible to use "filter" parameter
>
> I checked code and I can see that the jql query is missing the filter
> parameter to be set in the builder.
> Easy fix.
>
> I checked out the code:
>
> https://github.com/apache/maven-plugins
>
> I changed the code.
>
> How can I submit a patch and integrate it and test it? Make a release 2.13.
> What is the process? Is there a guide?
>
> Br,
>
> //mikael
>
>
>
>
>
>
>
>
> _______________________________________________
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/Help-to-submit-fix-in-maven-changes-plugin-tp5878947.html
> To start a new topic under Maven Developers, email
> ml-node+s40175n142166h86@n5.nabble.com
> To unsubscribe from Maven Developers, visit
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==
--
Cheers
Tibor
--
View this message in context: http://maven.40175.n5.nabble.com/Help-to-submit-fix-in-maven-changes-plugin-tp5878947p5878960.html
Sent from the Maven Developers mailing list archive at Nabble.com.