[jira] [Commented] (CLOUDSTACK-4095) Region id within the Database Transaction code...

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796818#comment-13796818 ] 

ASF subversion and git services commented on CLOUDSTACK-4095:
-------------------------------------------------------------

Commit e88377a5e50e6dcf296049a8c12517aeb6b2cac8 in branch refs/heads/4.2 from [~kishan]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e88377a ]

CLOUDSTACK-4095 : Remove region_id from Transaction. Read from db.properties whenever required


> Region id within the Database Transaction code...
> -------------------------------------------------
>
>                 Key: CLOUDSTACK-4095
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4095
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.2.0
>            Reporter: Alex Huang
>            Assignee: Kishan Kavala
>            Priority: Critical
>             Fix For: 4.2.1
>
>
> Why should the region id be in Transaction Id and then propagated through GenericDao.  This is should not happen at all.  We need to fix this.  GenericDao is a generic framework.  It should not understand regions at all.  Even if you're using the db.properties to expose region id, you can read it yourself in your code, rather than pushing it into Transaction.



--
This message was sent by Atlassian JIRA
(v6.1#6144)