[GitHub] [incubator-nuttx] davids5 edited a comment on issue #676: Fixes build issues associated with ARMv7-m mpu source files.

[GitBox <gi...@apache.org>]

davids5 edited a comment on issue #676: Fixes build issues associated with ARMv7-m mpu source files.
URL: https://github.com/apache/incubator-nuttx/pull/676#issuecomment-608331742
 
 
   @johannes-nivus Thank you so much for looking into this! 
   
   In defines only can we look at tracking the position of ")" and the offset to the "/*" and do the reset on the index of (line[n-1],")")  < (line[n],")") and if the offset of "/" == the last offset accept it?
   
   So the following would pass
   ```
   #  define MPU_RASR_TEX_MASK     (7 << MPU_RASR_TEX_SHIFT)
   #    define MPU_RASR_TEX_SO     (0 << MPU_RASR_TEX_SHIFT) /* Strongly Ordered */
   #    define MPU_RASR_TEX_NOR    (1 << MPU_RASR_TEX_SHIFT) /* Normal */
   #    define MPU_RASR_TEX_DEV    (2 << MPU_RASR_TEX_SHIFT) /* Device */
   #    define MPU_RASR_TEX_BB(bb) ((4|(bb)) << MPU_RASR_TEX_SHIFT) /* Normal BB AA */
   
   #      define MPU_RASR_CP_NC    (0)  /* Non-cacheable */
   #      define MPU_RASR_CP_WBRA  (1)  /* Write back, write and Read- Allocate */
   #      define MPU_RASR_CP_WT    (2)  /* Write through, no Write-Allocate */
   #      define MPU_RASR_CP_WB    (4)  /* Write back, no Write-Allocate */
   #  define MPU_RASR_AP_SHIFT     (24) /* Bits 24-26: Access permission */
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services