You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "nabarunnag (GitHub)" <gi...@apache.org> on 2019/02/28 20:10:41 UTC
[GitHub] [geode] nabarunnag opened pull request #3252: [DO NOT
REVIEW] GEODE-6470: Making double-checked locking thread-safe
* A repeated check on a non-volatile field is not thread-safe, and could result in unexpected behavior.
* Fixed using volatile and local variables
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3252 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag commented on pull request #3252:
GEODE-6470: Making double-checked locking thread-safe
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
The double checking is done in getSerializedValue, the local variable use was present but the value was not volatile, which is recommended post jdk5
[ Full content available at: https://github.com/apache/geode/pull/3252 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag commented on pull request #3252:
GEODE-6470: Making double-checked locking thread-safe
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
@jdeppe-pivotal
The double checking is done in getConnection, Updating to use local variables too
[ Full content available at: https://github.com/apache/geode/pull/3252 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag closed pull request #3252: GEODE-6470:
Making double-checked locking thread-safe
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/3252 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3252:
GEODE-6470: Making double-checked locking thread-safe
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
Did you mean to make this `volatile`? It seems unrelated.
[ Full content available at: https://github.com/apache/geode/pull/3252 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org