You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/22 08:18:34 UTC
Review Request 38595: Removed implicit logging from Socket::shutdown
in favor of returning a Try.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38595/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone.
Repository: mesos
Description
-------
See summary, should this also not be an ERROR?
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp a677e29b28711fc065134c11792b4f62fa3aa8b4
3rdparty/libprocess/src/libevent_ssl_socket.hpp 3b17fa278a92461cf74179084a717909224c3d9c
3rdparty/libprocess/src/libevent_ssl_socket.cpp 80db6e83f14de5fd241565009d8a60aa964e790c
3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e
Diff: https://reviews.apache.org/r/38595/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38595: Removed implicit logging from
Socket::shutdown in favor of returning a Try.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38595/#review100258
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38595/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary, should this also not be an ERROR?
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp a677e29b28711fc065134c11792b4f62fa3aa8b4
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp 3b17fa278a92461cf74179084a717909224c3d9c
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp 80db6e83f14de5fd241565009d8a60aa964e790c
> 3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e
>
> Diff: https://reviews.apache.org/r/38595/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38595: Removed implicit logging from
Socket::shutdown in favor of returning a Try.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38595/#review100630
-----------------------------------------------------------
Ship it!
Could you ping me to discuss this question "should this also not be an ERROR?" Thanks!
- Joris Van Remoortere
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38595/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary, should this also not be an ERROR?
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp a677e29b28711fc065134c11792b4f62fa3aa8b4
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp 3b17fa278a92461cf74179084a717909224c3d9c
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp 80db6e83f14de5fd241565009d8a60aa964e790c
> 3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e
>
> Diff: https://reviews.apache.org/r/38595/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>