You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/20 12:27:18 UTC
[GitHub] [doris] starocean999 opened a new pull request, #16126: [fix](be)the set operation node create result block using row_desc()
starocean999 opened a new pull request, #16126:
URL: https://github.com/apache/doris/pull/16126
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node create result block using row_desc()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1398398242
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node create result block using row_desc()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1398316908
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by github-actions.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1407614371
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by github-actions.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1411463523
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #16126:
URL: https://github.com/apache/doris/pull/16126#discussion_r1091576685
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -239,13 +239,22 @@ Status VSetOperationNode<is_intersect>::prepare(RuntimeState* state) {
_pull_timer = ADD_TIMER(runtime_profile(), "PullTime");
// Prepare result expr lists.
+ vector<bool> nullable_flags;
+ nullable_flags.resize(_child_expr_lists[0].size(), false);
for (int i = 0; i < _child_expr_lists.size(); ++i) {
+ int j = 0;
+ for (auto ctx : _child_expr_lists[i]) {
+ nullable_flags[j] = nullable_flags[j] || ctx->root()->is_nullable();
+ ++j;
+ }
RETURN_IF_ERROR(VExpr::prepare(_child_expr_lists[i], state, child(i)->row_desc()));
}
-
+ int n = 0;
for (auto ctx : _child_expr_lists[0]) {
- _build_not_ignore_null.push_back(ctx->root()->is_nullable());
Review Comment:
save to upper
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -239,13 +239,22 @@ Status VSetOperationNode<is_intersect>::prepare(RuntimeState* state) {
_pull_timer = ADD_TIMER(runtime_profile(), "PullTime");
// Prepare result expr lists.
+ vector<bool> nullable_flags;
+ nullable_flags.resize(_child_expr_lists[0].size(), false);
for (int i = 0; i < _child_expr_lists.size(); ++i) {
+ int j = 0;
+ for (auto ctx : _child_expr_lists[i]) {
Review Comment:
better directly use ```for(int j = 0; j < _child_expr_lists[i].size()```
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -239,13 +239,22 @@ Status VSetOperationNode<is_intersect>::prepare(RuntimeState* state) {
_pull_timer = ADD_TIMER(runtime_profile(), "PullTime");
// Prepare result expr lists.
+ vector<bool> nullable_flags;
+ nullable_flags.resize(_child_expr_lists[0].size(), false);
for (int i = 0; i < _child_expr_lists.size(); ++i) {
+ int j = 0;
+ for (auto ctx : _child_expr_lists[i]) {
Review Comment:
better directly use ```for(int j = 0; j < _child_expr_lists[i].size()```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1415743892
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by github-actions.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1407624624
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node create result block using row_desc()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1398398163
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #16126:
URL: https://github.com/apache/doris/pull/16126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16126: [fix](be)the set operation node create result block using row_desc()
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16126:
URL: https://github.com/apache/doris/pull/16126#issuecomment-1398333943
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.85 seconds
load time: 510 seconds
storage size: 17123025257 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230120124919_clickbench_pr_84724.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #16126:
URL: https://github.com/apache/doris/pull/16126#discussion_r1091576401
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -239,13 +239,22 @@ Status VSetOperationNode<is_intersect>::prepare(RuntimeState* state) {
_pull_timer = ADD_TIMER(runtime_profile(), "PullTime");
// Prepare result expr lists.
+ vector<bool> nullable_flags;
+ nullable_flags.resize(_child_expr_lists[0].size(), false);
for (int i = 0; i < _child_expr_lists.size(); ++i) {
+ int j = 0;
+ for (auto ctx : _child_expr_lists[i]) {
Review Comment:
better directly use ```for(int j = 0; j < _child_expr_lists[i].size()```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org