You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/24 16:34:26 UTC
[GitHub] [flink-statefun] tzulitai opened a new pull request #202: [FLINK-21491] Properly shade Protobuf in Java SDK
tzulitai opened a new pull request #202:
URL: https://github.com/apache/flink-statefun/pull/202
This PR contains mainly of 2 important changes:
- Create our own modules that shades Protobuf + declare the `protobuf-java` dependency (which is required only by the protoc maven plugin) to be provided, so that it doesn't get pulled in as a transitive dependency by users.
- Let the Java SDK depend on this new module, instead of `protobuf-java` directly.
---
# Verifying this change
- Running `mvn dependency:tree` under `statefun-sdk-java` should reveal that `com.google.protobuf:protobuf-java` is no longer a compile dependency.
- After building the project + reloading Maven in the IDE, there should be no warnings or errors in the IDE, meaning that all references in the Java SDK to Protobuf classes and protocol message Java classes are pointing to already relocated sources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tzulitai closed pull request #202: [FLINK-21491] Properly shade Protobuf in Java SDK
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #202:
URL: https://github.com/apache/flink-statefun/pull/202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org