[GitHub] [guacamole-client] mike-jumper commented on pull request #573: GUACAMOLE-680: Implement a guaranteed logout handler hook

[GitBox <gi...@apache.org>]

mike-jumper commented on pull request #573:
URL: https://github.com/apache/guacamole-client/pull/573#issuecomment-785454021


   > ...
   >
   > I like this idea. I took a look at the Event Target that you linked above and I think I would run into the same shortcoming that I had in my use case of making a REST call in the listener function. I don't want the listener function to be marked as 'done' until the REST call out to the Identity Provider is done and I call some kind of 'resolve' or 'success' callback.
   >
   > I think it is feasible for me to do some refactoring on the event target to use the [Promises API](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise). Does that sound like what you had in mind?
   
   I'd think either implementation would allow an extension to reliably hook into application logout. Is your concern that you want to be able to manually reject the promise returned by `authenticationService.logout()` from within a logout hook?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org