[GitHub] [accumulo] cshannon commented on pull request #3067: Reduce logging when external compactions are cancelled

[GitBox <gi...@apache.org>]

cshannon commented on PR #3067:
URL: https://github.com/apache/accumulo/pull/3067#issuecomment-1304839506

   > I think these changes are okay, but I'm not sure it's going to help folks who typically leave the debug logs enabled. In fact, it may make things worse for them, because now there's extra log statements, the basic one at warn and the more detailed stack trace at debug.
   
   I suppose one thing we could do is only log one statement regardless depending on what is enabled so we don't have the second log statement. We could add back in the debug is enabled check, and if it is, then only log the full stack trace (either at debug level or even error/warn level) and if it's not enabled then just log the 1 line statement and no stack trace.
   
   But, in my opinion, that isn't necessary and the change here should be ok as is. I'm not really worried about the extra log statements because if someone turns on debug then they should expect to get flooded with log statements and information as that is the entire point. To me this is about fixing the non-debug use case (ie not development but production) where you don't want see a bunch of extra stuff that isn't a big deal and you wouldn't leave debug turned on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org