You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/04 19:42:13 UTC

[GitHub] [geode] Bill opened a new pull request #5703: ByteBufferSharingImpl: only ever return buffer to pool once

Bill opened a new pull request #5703:
URL: https://github.com/apache/geode/pull/5703


   Fix data race in `ByteBufferSharingImpl` that was causing us to re-pool a `ByteBuffer` more than once.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #5703: ByteBufferSharingImpl: only ever return buffer to pool once

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5703:
URL: https://github.com/apache/geode/pull/5703#issuecomment-723372273


   this experiment resulted in a new set of PRs for GEODE-8652


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill closed pull request #5703: ByteBufferSharingImpl: only ever return buffer to pool once

Posted by GitBox <gi...@apache.org>.
Bill closed pull request #5703:
URL: https://github.com/apache/geode/pull/5703


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org