You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/05 15:14:30 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5175: Minor fix for input Kconfig
xiaoxiang781216 opened a new pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175
## Summary
- input: Remove prompt string from INPUT_MOUSE
- usbhost: Fix typo error in Kconfig(MOUSE->INPUT_MOUSE)
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5175: Minor fix for input Kconfig
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175#discussion_r779149602
##########
File path: drivers/input/Kconfig
##########
@@ -14,7 +14,7 @@ menuconfig INPUT
if INPUT
config INPUT_MOUSE
- bool "Enable mouse support"
Review comment:
If it is a "hidden" bool shouldn't the help go away also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5175: Minor fix for input Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5175: Minor fix for input Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175#discussion_r779258518
##########
File path: drivers/input/Kconfig
##########
@@ -14,7 +14,7 @@ menuconfig INPUT
if INPUT
config INPUT_MOUSE
- bool "Enable mouse support"
Review comment:
Even it's a hidden option, the mouse driver dev can get help from it when he add new driver option to Kconfig file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5175: Minor fix for input Kconfig
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175#discussion_r779102212
##########
File path: drivers/input/Kconfig
##########
@@ -14,7 +14,7 @@ menuconfig INPUT
if INPUT
config INPUT_MOUSE
- bool "Enable mouse support"
Review comment:
INPUT_MOUSE is only a flag to indicate we have mouse support, it is activated by other device drivers that implement some kind of "mouse". Note there is not a mouse.c file or equivalent to be compiled when INPUT_MOUSE is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5175: Minor fix for input Kconfig
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175#discussion_r778951401
##########
File path: drivers/input/Kconfig
##########
@@ -14,7 +14,7 @@ menuconfig INPUT
if INPUT
config INPUT_MOUSE
- bool "Enable mouse support"
Review comment:
Why the text is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org