You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Luis De Pombo <lf...@gmail.com> on 2015/06/03 02:24:40 UTC
Re: Review Request 34011: Add support for a Graphite Metrics Reporter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34011/
-----------------------------------------------------------
(Updated June 3, 2015, 12:24 a.m.)
Review request for samza.
Repository: samza
Description
-------
Add support for a Graphite Metrics Reporter
Diffs (updated)
-----
build.gradle a5f54106a822dc91ff82270df27217a8765a0d80
checkstyle/import-control.xml 5f8e103a2e43f96518b20de1c7cbd84e0af24842
docs/learn/documentation/versioned/container/metrics.md 11a62f9c8bb8b7a448714a81c8ab08c6a0375562
docs/learn/documentation/versioned/jobs/configuration-table.html 405e2cea4fd1d037cc26b3537f6bb406eded202b
gradle/dependency-versions.gradle d79213f6237d8026d2c83a415d1a8fb2e2976d40
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteCounter.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteGauge.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteReporterFactory.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteTimer.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteCounterTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteGaugeTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteSnapshotTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteTimerTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporterTest.java PRE-CREATION
settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
Diff: https://reviews.apache.org/r/34011/diff/
Testing
-------
Thanks,
Luis De Pombo
Re: Review Request 34011: Add support for a Graphite Metrics Reporter
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34011/#review87763
-----------------------------------------------------------
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java
<https://reviews.apache.org/r/34011/#comment140181>
Does it makes sense to move this to the Snapshot?
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java
<https://reviews.apache.org/r/34011/#comment140200>
this seems not necessary.
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java
<https://reviews.apache.org/r/34011/#comment140201>
same as above
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java
<https://reviews.apache.org/r/34011/#comment140202>
same as above
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java
<https://reviews.apache.org/r/34011/#comment140203>
same
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java
<https://reviews.apache.org/r/34011/#comment140204>
same
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java
<https://reviews.apache.org/r/34011/#comment140205>
same
- Yan Fang
On June 11, 2015, 5:54 p.m., Luis De Pombo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34011/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 5:54 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Add support for a Graphite Metrics Reporter
>
>
> Diffs
> -----
>
> build.gradle a5f54106a822dc91ff82270df27217a8765a0d80
> checkstyle/import-control.xml 3374f0c432e61ac4cda275377604cfd481f0cddf
> docs/learn/documentation/versioned/container/metrics.md 11a62f9c8bb8b7a448714a81c8ab08c6a0375562
> docs/learn/documentation/versioned/jobs/configuration-table.html 405e2cea4fd1d037cc26b3537f6bb406eded202b
> gradle/dependency-versions.gradle d79213f6237d8026d2c83a415d1a8fb2e2976d40
> samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteCounter.java PRE-CREATION
> samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteGauge.java PRE-CREATION
> samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteReporterFactory.java PRE-CREATION
> samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java PRE-CREATION
> samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteTimer.java PRE-CREATION
> samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java PRE-CREATION
> samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteCounterTest.java PRE-CREATION
> samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteGaugeTest.java PRE-CREATION
> samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteSnapshotTest.java PRE-CREATION
> samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteTimerTest.java PRE-CREATION
> samza-graphite/src/test/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporterTest.java PRE-CREATION
> settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
>
> Diff: https://reviews.apache.org/r/34011/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luis De Pombo
>
>
Re: Review Request 34011: Add support for a Graphite Metrics Reporter
Posted by Luis De Pombo <lf...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34011/
-----------------------------------------------------------
(Updated June 11, 2015, 5:54 p.m.)
Review request for samza.
Repository: samza
Description
-------
Add support for a Graphite Metrics Reporter
Diffs (updated)
-----
build.gradle a5f54106a822dc91ff82270df27217a8765a0d80
checkstyle/import-control.xml 3374f0c432e61ac4cda275377604cfd481f0cddf
docs/learn/documentation/versioned/container/metrics.md 11a62f9c8bb8b7a448714a81c8ab08c6a0375562
docs/learn/documentation/versioned/jobs/configuration-table.html 405e2cea4fd1d037cc26b3537f6bb406eded202b
gradle/dependency-versions.gradle d79213f6237d8026d2c83a415d1a8fb2e2976d40
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteCounter.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteGauge.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteReporterFactory.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteTimer.java PRE-CREATION
samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteCounterTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteGaugeTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteSnapshotTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteTimerTest.java PRE-CREATION
samza-graphite/src/test/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporterTest.java PRE-CREATION
settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
Diff: https://reviews.apache.org/r/34011/diff/
Testing
-------
Thanks,
Luis De Pombo