You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/09 17:59:54 UTC

[GitHub] [pulsar] sursingh opened a new pull request #10877: Make MetadataCacheTest reliable.

sursingh opened a new pull request #10877:
URL: https://github.com/apache/pulsar/pull/10877


   Fixes #10872 
   
   ### Motivation
   
   Cache updates are asynchronous. Due to this the test could sometime fail. This makes the test flaky
   MetadataCacheTest
   
   ### Modifications
   
   Use Awaitility module to more reliably check for the test conditions
   
   ### Verifying this change
   
   - [X] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema:  (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   A simple bugfix in test code. Doen't need any doc updates
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
     - If a feature is not applicable for documentation, explain why? 
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] bharanic-dev commented on pull request #10877: Make MetadataCacheTest reliable.

Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #10877:
URL: https://github.com/apache/pulsar/pull/10877#issuecomment-858050036


   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10877: Make MetadataCacheTest reliable.

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10877:
URL: https://github.com/apache/pulsar/pull/10877


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sursingh commented on pull request #10877: Make MetadataCacheTest reliable.

Posted by GitBox <gi...@apache.org>.
sursingh commented on pull request #10877:
URL: https://github.com/apache/pulsar/pull/10877#issuecomment-857921215


   @lhotari: can you please help with the review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org