You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/29 15:06:30 UTC
[GitHub] [ignite] vveider opened a new pull request #8731: IGNITE-14017 Willing to add s390x support to the docker image
vveider opened a new pull request #8731:
URL: https://github.com/apache/ignite/pull/8731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] vveider commented on a change in pull request #8731: IGNITE-14017 Willing to add s390x support to the docker image
Posted by GitBox <gi...@apache.org>.
vveider commented on a change in pull request #8731:
URL: https://github.com/apache/ignite/pull/8731#discussion_r638770679
##########
File path: deliveries/docker/apache-ignite/s390x/Dockerfile
##########
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# Base Image
+FROM s390x/ubuntu:18.04
+
+ARG IGNITE_VER=2.9.1
Review comment:
Version hardcode is not recommended — it is difficult to maintain.
Instead either mandatory variable without default value or prepared Apache Ignite directory without version should be introduced.
##########
File path: deliveries/docker/apache-ignite/s390x/Dockerfile
##########
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# Base Image
+FROM s390x/ubuntu:18.04
+
+ARG IGNITE_VER=2.9.1
+
+# The Author
+LABEL maintainer="LoZ Open Source Ecosystem (https://www.ibm.com/community/z/usergroups/opensource)"
+
+# Set Environment Variables
+ENV WORKDIR /root
Review comment:
`/opt` is better for custom sofware
##########
File path: deliveries/docker/apache-ignite/s390x/Dockerfile
##########
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# Base Image
+FROM s390x/ubuntu:18.04
+
+ARG IGNITE_VER=2.9.1
+
+# The Author
+LABEL maintainer="LoZ Open Source Ecosystem (https://www.ibm.com/community/z/usergroups/opensource)"
+
+# Set Environment Variables
+ENV WORKDIR /root
+ENV JAVA_HOME=$WORKDIR/jdk-11.0.7+10
+ENV IGNITE_HOME=$WORKDIR/apache-ignite-${IGNITE_VER}-bin
+ENV PATH=$JAVA_HOME/bin:$WORKDIR/apache-ignite-${IGNITE_VER}-bin/bin:$PATH
+
+# Install Dependencies
+RUN apt-get update && apt-get install -y \
+ wget \
+ tar \
+ unzip \
+# Download AdoptOpenJDK 8
+ && cd $WORKDIR \
+ && wget https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.7%2B10_openj9-0.20.0/OpenJDK11U-jdk_s390x_linux_openj9_11.0.7_10_openj9-0.20.0.tar.gz \
+ && tar xvf OpenJDK11U-jdk_s390x_linux_openj9_11.0.7_10_openj9-0.20.0.tar.gz \
+# Install Apache Ignite
+ && cd $WORKDIR \
+ && wget https://archive.apache.org/dist/ignite/${IGNITE_VER}/apache-ignite-${IGNITE_VER}-bin.zip \
+ && unzip -q apache-ignite-${IGNITE_VER}-bin.zip \
+# Clean up cache data and remove dependencies that are not required
+ && apt-get remove -y \
+ wget \
+ unzip \
+ && apt-get autoremove -y \
+ && apt autoremove -y \
+ && apt-get clean && rm -rf /var/lib/apt/lists/* $WORKDIR/apache-ignite-${IGNITE_VER}-bin.zip $WORKDIR/OpenJDK11U-jdk_s390x_linux_openj9_11.0.7_10_openj9-0.20.0.tar.gz
+
+# Copy sh files and set permission
+COPY run.sh $IGNITE_HOME/
+# Grant permission to copy optional libs
+RUN chmod 777 ${IGNITE_HOME}/libs
+# Grant permission to create work directory
+RUN chmod 777 ${IGNITE_HOME}
Review comment:
Can be united with chmod above
##########
File path: deliveries/docker/apache-ignite/s390x/Dockerfile
##########
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# Base Image
+FROM s390x/ubuntu:18.04
+
+ARG IGNITE_VER=2.9.1
+
+# The Author
+LABEL maintainer="LoZ Open Source Ecosystem (https://www.ibm.com/community/z/usergroups/opensource)"
+
+# Set Environment Variables
+ENV WORKDIR /root
+ENV JAVA_HOME=$WORKDIR/jdk-11.0.7+10
+ENV IGNITE_HOME=$WORKDIR/apache-ignite-${IGNITE_VER}-bin
+ENV PATH=$JAVA_HOME/bin:$WORKDIR/apache-ignite-${IGNITE_VER}-bin/bin:$PATH
+
+# Install Dependencies
+RUN apt-get update && apt-get install -y \
+ wget \
+ tar \
+ unzip \
+# Download AdoptOpenJDK 8
+ && cd $WORKDIR \
+ && wget https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.7%2B10_openj9-0.20.0/OpenJDK11U-jdk_s390x_linux_openj9_11.0.7_10_openj9-0.20.0.tar.gz \
Review comment:
Get, unpack and cleanup should be united in single layer.
And be separated with standalone RUN command
##########
File path: deliveries/docker/apache-ignite/s390x/Dockerfile
##########
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# Base Image
+FROM s390x/ubuntu:18.04
+
+ARG IGNITE_VER=2.9.1
+
+# The Author
+LABEL maintainer="LoZ Open Source Ecosystem (https://www.ibm.com/community/z/usergroups/opensource)"
+
+# Set Environment Variables
+ENV WORKDIR /root
+ENV JAVA_HOME=$WORKDIR/jdk-11.0.7+10
+ENV IGNITE_HOME=$WORKDIR/apache-ignite-${IGNITE_VER}-bin
+ENV PATH=$JAVA_HOME/bin:$WORKDIR/apache-ignite-${IGNITE_VER}-bin/bin:$PATH
+
+# Install Dependencies
+RUN apt-get update && apt-get install -y \
+ wget \
+ tar \
+ unzip \
+# Download AdoptOpenJDK 8
+ && cd $WORKDIR \
+ && wget https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.7%2B10_openj9-0.20.0/OpenJDK11U-jdk_s390x_linux_openj9_11.0.7_10_openj9-0.20.0.tar.gz \
+ && tar xvf OpenJDK11U-jdk_s390x_linux_openj9_11.0.7_10_openj9-0.20.0.tar.gz \
+# Install Apache Ignite
+ && cd $WORKDIR \
+ && wget https://archive.apache.org/dist/ignite/${IGNITE_VER}/apache-ignite-${IGNITE_VER}-bin.zip \
+ && unzip -q apache-ignite-${IGNITE_VER}-bin.zip \
+# Clean up cache data and remove dependencies that are not required
+ && apt-get remove -y \
Review comment:
apt clean should be done with apt install / update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] imurchenko commented on pull request #8731: IGNITE-14017 Willing to add s390x support to the docker image
Posted by GitBox <gi...@apache.org>.
imurchenko commented on pull request #8731:
URL: https://github.com/apache/ignite/pull/8731#issuecomment-888896788
Looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov merged pull request #8731: IGNITE-14017 Willing to add s390x support to the docker image
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #8731:
URL: https://github.com/apache/ignite/pull/8731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org