You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/27 18:32:44 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #2759: esp32/psram: Fix missing configs
acassis opened a new pull request #2759:
URL: https://github.com/apache/incubator-nuttx/pull/2759
## Summary
esp32/psram: Fix missing configs
## Impact
Default configuration will work even without board pin definition
## Testing
ESP32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2759: esp32/psram: Fix missing configs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2759:
URL: https://github.com/apache/incubator-nuttx/pull/2759#discussion_r565778356
##########
File path: arch/xtensa/src/esp32/esp32_psram.c
##########
@@ -153,7 +153,11 @@
#define PICO_PSRAM_CLK_IO 6
#ifndef CONFIG_PICO_PSRAM_CS_IO /* Default is 10 */
-# define PICO_PSRAM_CS_IO 10
+# define CONFIG_PICO_PSRAM_CS_IO 10
Review comment:
should we keep the alignment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2759: esp32/psram: Fix missing configs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2759:
URL: https://github.com/apache/incubator-nuttx/pull/2759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2759: esp32/psram: Fix missing configs
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2759:
URL: https://github.com/apache/incubator-nuttx/pull/2759#discussion_r565978914
##########
File path: arch/xtensa/src/esp32/esp32_psram.c
##########
@@ -153,7 +153,11 @@
#define PICO_PSRAM_CLK_IO 6
#ifndef CONFIG_PICO_PSRAM_CS_IO /* Default is 10 */
-# define PICO_PSRAM_CS_IO 10
+# define CONFIG_PICO_PSRAM_CS_IO 10
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org