You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/17 13:12:56 UTC
[GitHub] [skywalking] JaredTan95 opened a new pull request #4079: fix
ServiceInstanceInventory.Builder#map2Data NPE.
JaredTan95 opened a new pull request #4079: fix ServiceInstanceInventory.Builder#map2Data NPE.
URL: https://github.com/apache/skywalking/pull/4079
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
`org.apache.skywalking.oap.server.core.register.ServiceInstanceInventory#setNodeType` causes NPE when `io.daocloud.dmp.skywalking.query.server.repository.ServiceInstanceInventoryRepositoryImpl#get(java.lang.String, int)` method invoked.
And this exception caused by not set `NodeType` during ServiceInstanceRegister.
- How to fix?
Set default `NodeType` when serviceInstanceInventory first time be created.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services