You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/03/06 20:59:21 UTC

[GitHub] [incubator-heron] Code0x58 commented on pull request #3786: Fix for missing physical plan in UI

Code0x58 commented on pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1060037824


   > I'm running into some other issues with parameter mismatch betwen `ui` and `tracker`. So I'm doing a bit of testing. One example is `topology` vs `topology_name`. There is an alias [here](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/metrics.py#L106), but it didn't seem to work. I was testing with a failed Tracker API call and got different response when using either `topology` or `topology_name`. Perhaps the `alias` isn't working? @Code0x58 might have some insight in helping answer that question.
   
   It looks like alias may be a bit of a misnomer, it may be better to call it `source`, if this [reference](https://fastapi.tiangolo.com/tutorial/query-params-str-validations/#alias-parameters) covers everything


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org