You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/11/14 09:36:40 UTC

[GitHub] [hbase] meszibalu commented on a diff in pull request #4879: HBASE-27435 Make Prometheus metrics queryable

meszibalu commented on code in PR #4879:
URL: https://github.com/apache/hbase/pull/4879#discussion_r1021266349


##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoopServlet.java:
##########
@@ -35,13 +35,18 @@
 
 @InterfaceAudience.Private
 public class PrometheusHadoopServlet extends HttpServlet {
+  private boolean descriptionEnabled;
+  private String queryParam;

Review Comment:
   Servlets should be stateless. There is only one `PrometheusHadoopServlet` in the JVM, so it can lead to concurrency issues when multiple requests are coming in the same time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org